Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev/build/sass] build stylesheets for disabled plugins too #54654

Merged
merged 1 commit into from
Jan 13, 2020
Merged

[dev/build/sass] build stylesheets for disabled plugins too #54654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/dev/sass/build_sass.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

import { resolve } from 'path';

import * as Rx from 'rxjs';
import { toArray } from 'rxjs/operators';

import { createFailError } from '@kbn/dev-utils';
Expand Down Expand Up @@ -61,9 +62,11 @@ export async function buildSass({ log, kibanaDir, watch }) {

const scanDirs = [resolve(kibanaDir, 'src/legacy/core_plugins')];
const paths = [resolve(kibanaDir, 'x-pack')];
const { spec$ } = findPluginSpecs({ plugins: { scanDirs, paths } });
const enabledPlugins = await spec$.pipe(toArray()).toPromise();
const uiExports = collectUiExports(enabledPlugins);
const { spec$, disabledSpec$ } = findPluginSpecs({ plugins: { scanDirs, paths } });
const allPlugins = await Rx.merge(spec$, disabledSpec$)
.pipe(toArray())
.toPromise();
const uiExports = collectUiExports(allPlugins);
const { styleSheetPaths } = uiExports;

log.info('%s %d styleSheetPaths', watch ? 'watching' : 'found', styleSheetPaths.length);
Expand Down