fixing color and toggle accessibility #54661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timductive
added
release_note:fix
Project:Accessibility
Team:Presentation
|
Pinging @elastic/kibana-canvas (Team:Canvas) |
timductive
force-pushed
the
a11y-fixes
branch
from
ed5b1ef to
ed662a9
Compare
myasonik
approved these changes
Jan 14, 2020
There was a problem hiding this comment.
Don't have time at the moment to pull down and confirm locally but the code looks good.
If possible, let's get this into 7.6 because no matter what this will likely be an improvement to what's currently there and I'll review it later in the week to see if we need to do another pass over anything.
|
@elasticmachine merge upstream |
crob611
approved these changes
Jan 14, 2020
| @@ -26,6 +26,8 @@ const ToggleArgInput = ({ onValueChange, argValue, argId, renderError }) => { | |||
| checked={argValue} | |||
| onChange={handleChange} | |||
| className="canvasArg__switch" | |||
| aria-label={typeInstance.displayName} | |||
| showLabel={false} | |||
There was a problem hiding this comment.
This showLabel=false is causing some warning in the console
EuiSwitch 'label' must be a string when 'showLabel' is false.
timductive
force-pushed
the
a11y-fixes
branch
from
f95753b to
050beb9
Compare
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
timductive
added a commit
to timductive/kibana
that referenced
this pull request
Jan 14, 2020
* fixing color and toggle accessibility * updating snapshots * fixing more snapshots * fixing toggle console warning
timductive
added a commit
that referenced
this pull request
Jan 14, 2020
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 17, 2020
* fixing color and toggle accessibility * updating snapshots * fixing more snapshots * fixing toggle console warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixing accessibility labels for color button, grid, palettes and toggles.
closes #25509
closes #25510
Checklist
For maintainers