-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Fixes empty table header cell and duplicate ID accessibility issues #54917
Merged
peteharverson
merged 2 commits into
elastic:master
from
peteharverson:ml-table-accessibility-fixes
Jan 16, 2020
Merged
[ML] Fixes empty table header cell and duplicate ID accessibility issues #54917
peteharverson
merged 2 commits into
elastic:master
from
peteharverson:ml-table-accessibility-fixes
Jan 16, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
review
release_note:fix
Project:Accessibility
:ml
Feature:Anomaly Detection
ML anomaly detection
v8.0.0
Feature:Transforms
ML transforms
Feature:Data Frame Analytics
ML data frame analytics features
v7.7.0
v7.6.0
labels
Jan 15, 2020
peteharverson
requested review from
darnautov,
alvarezmelissa87 and
jgowdyelastic
January 15, 2020 15:33
Pinging @elastic/ml-ui (:ml) |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
alvarezmelissa87
approved these changes
Jan 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ⚡️
jgowdyelastic
approved these changes
Jan 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Jan 16, 2020
…ues (elastic#54917) * [ML] Fixes empty table header cell and duplicate ID accessibility issues * [ML] Fix anomalies table columns test
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Jan 16, 2020
…ues (elastic#54917) * [ML] Fixes empty table header cell and duplicate ID accessibility issues * [ML] Fix anomalies table columns test
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 17, 2020
…ues (elastic#54917) * [ML] Fixes empty table header cell and duplicate ID accessibility issues * [ML] Fix anomalies table columns test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Anomaly Detection
ML anomaly detection
Feature:Data Frame Analytics
ML data frame analytics features
Feature:Transforms
ML transforms
:ml
Project:Accessibility
release_note:fix
review
v7.6.0
v7.7.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a couple of accessibility issues on table components in the ML and Transforms plugins.
id
attribute from the actions popover.Checklist
For maintainers