Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fixes empty table header cell and duplicate ID accessibility issues #54917

Merged

Conversation

peteharverson
Copy link
Contributor

@peteharverson peteharverson commented Jan 15, 2020

Summary

Fixes a couple of accessibility issues on table components in the ML and Transforms plugins.

Checklist

For maintainers

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peteharverson peteharverson merged commit 3419b06 into elastic:master Jan 16, 2020
@peteharverson peteharverson deleted the ml-table-accessibility-fixes branch January 16, 2020 14:19
peteharverson added a commit to peteharverson/kibana that referenced this pull request Jan 16, 2020
…ues (elastic#54917)

* [ML] Fixes empty table header cell and duplicate ID accessibility issues

* [ML] Fix anomalies table columns test
peteharverson added a commit to peteharverson/kibana that referenced this pull request Jan 16, 2020
…ues (elastic#54917)

* [ML] Fixes empty table header cell and duplicate ID accessibility issues

* [ML] Fix anomalies table columns test
peteharverson added a commit that referenced this pull request Jan 16, 2020
…ues (#54917) (#55046)

* [ML] Fixes empty table header cell and duplicate ID accessibility issues

* [ML] Fix anomalies table columns test
peteharverson added a commit that referenced this pull request Jan 16, 2020
…ues (#54917) (#55047)

* [ML] Fixes empty table header cell and duplicate ID accessibility issues

* [ML] Fix anomalies table columns test
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 17, 2020
…ues (elastic#54917)

* [ML] Fixes empty table header cell and duplicate ID accessibility issues

* [ML] Fix anomalies table columns test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants