Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export new ui settings types and regenerate docs #55020

Merged
merged 2 commits into from
Jan 16, 2020
Merged

Export new ui settings types and regenerate docs #55020

merged 2 commits into from
Jan 16, 2020

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Jan 16, 2020

Summary

Export new ui settings types and regenerate docs

  • DeprecationSettings
  • ImageValidation
  • StringValidation

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@lizozom lizozom added v8.0.0 Team:AppArch release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Jan 16, 2020
@lizozom lizozom requested a review from a team as a code owner January 16, 2020 10:51
@lizozom lizozom self-assigned this Jan 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lizozom
Copy link
Contributor Author

lizozom commented Jan 16, 2020

@elasticmachine merge upstream

@lizozom lizozom mentioned this pull request Jan 16, 2020
Merged
7 tasks
@lizozom lizozom requested a review from pgayvallet January 16, 2020 11:42
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

pgayvallet
pgayvallet approved these changes Jan 16, 2020
View reviewed changes
src/core/server/index.ts
Comment on lines +219 to +221
ImageValidation,
DeprecationSettings,
StringValidation,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally now that these are public, and as they are very generic name with very specific usages, they should start with the UiSettings prefix to avoid conflicts.

@lizozom lizozom merged commit 12ec08e into elastic:master Jan 16, 2020
lizozom pushed a commit to lizozom/kibana that referenced this pull request Jan 16, 2020
@elasticmachine
export new ui settings types and regen docs (elastic#55020)
4c70153 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@lizozom lizozom mentioned this pull request Jan 16, 2020
Merged
lizozom pushed a commit that referenced this pull request Jan 16, 2020
@elasticmachine
export new ui settings types and regen docs (#55020) (#55072)
8782287 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 17, 2020
@elasticmachine @jkelastic
export new ui settings types and regen docs (elastic#55020)
51c23da 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees

@lizozom lizozom

Labels
release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lizozom @elasticmachine @kibanamachine @pgayvallet