Fix skipped alerting UI tests #55058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecote
added
Feature:Alerting
v8.0.0
release_note:skip
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
|
Runnings tests 42x to ensure no flakiness: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/136/. |
|
Another 42x run https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/139/. |
|
Running functional tests 42x to ensure no flakiness 🤞 https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/141/ |
|
@elasticmachine merge upstream |
gmmorris
approved these changes
Jan 24, 2020
...ggers_actions_ui/np_ready/public/application/sections/alerts_list/components/alerts_list.tsx
Outdated
Show resolved
Hide resolved
...ns_ui/np_ready/public/application/sections/alerts_list/components/collapsed_item_actions.tsx
Outdated
Show resolved
Hide resolved
...ggers_actions_ui/np_ready/public/application/sections/alerts_list/components/alerts_list.tsx
Outdated
Show resolved
Hide resolved
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Jan 24, 2020
* Fix skipped alerting UI tests * Fix switch click to use new pageobject function * Use .click function directly instead of find then click * Merge state variables into one for alerts and alert types * Fix flaky tests by fixing react code * Could this be it?? The one thing missing that caused all this flakiness?? * Cleanup convertAlertsToTableItems function * Remove I from interface names, fix disabled boolean logic Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
mikecote
added a commit
that referenced
this pull request
Jan 24, 2020
* Fix skipped alerting UI tests * Fix switch click to use new pageobject function * Use .click function directly instead of find then click * Merge state variables into one for alerts and alert types * Fix flaky tests by fixing react code * Could this be it?? The one thing missing that caused all this flakiness?? * Cleanup convertAlertsToTableItems function * Remove I from interface names, fix disabled boolean logic Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I'm re-enabling all the skipped tests from the alerting UI suite.
These tests were originally skipped due to an issue in EUI (elastic/eui#2612). Now that the issue is fixed, we can re-enable these tests.
While re-enabling, a small issues was found with the collapsed item component. I've fixed those in here as well. (The switch wouldn't reflect the result of a bulk action). The downside with my fix is the switch won't change value until the API call finishes and a re-render happens.
Other stability fixes:
.clickdirectly instead of.findthen.click(9e6f2c2)awaitthat caused tests to be flaky (aee22a5)Resolves #49830 now that we will have a full suite running.