Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing flaky CI tests for custom appRoutes #55763

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

eliperelman
Copy link
Contributor

@eliperelman eliperelman commented Jan 23, 2020

Summary

Resolve flakiness in CI tests for custom appRoutes.
Closes #55750

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@eliperelman eliperelman self-assigned this Jan 23, 2020
@eliperelman
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

user doesn't have permission to update head repository

@eliperelman
Copy link
Contributor Author

@elasticmachine merge upstream

8 similar comments
@eliperelman
Copy link
Contributor Author

@elasticmachine merge upstream

@eliperelman
Copy link
Contributor Author

@elasticmachine merge upstream

@eliperelman
Copy link
Contributor Author

@elasticmachine merge upstream

@eliperelman
Copy link
Contributor Author

@elasticmachine merge upstream

@eliperelman
Copy link
Contributor Author

@elasticmachine merge upstream

@eliperelman
Copy link
Contributor Author

@elasticmachine merge upstream

@eliperelman
Copy link
Contributor Author

@elasticmachine merge upstream

@eliperelman
Copy link
Contributor Author

@elasticmachine merge upstream

@eliperelman eliperelman marked this pull request as ready for review January 28, 2020 17:37
@eliperelman eliperelman requested review from brianseeders and a team January 28, 2020 17:37
@eliperelman eliperelman added bug Fixes for quality problems that affect the customer experience Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Jan 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@eliperelman eliperelman added v7.7.0 v8.0.0 release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. labels Jan 28, 2020
@eliperelman eliperelman force-pushed the bug/flaky-ci-approute-tests branch from 82bc3c5 to 55387e0 Compare January 30, 2020 22:22
@joshdover
Copy link
Contributor

@eliperelman anything we're waiting on here?

@mshustov
Copy link
Contributor

mshustov commented Feb 5, 2020

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

user doesn't have permission to update head repository

@eliperelman eliperelman force-pushed the bug/flaky-ci-approute-tests branch from 55387e0 to 7027ba6 Compare February 6, 2020 20:05
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

History

  • 💚 Build #23657 succeeded 55387e0ac1f064754276792b5f9d1b6b1d612df4
  • 💚 Build #23043 succeeded 82bc3c56da5bba006159bbf6053f527772218b90
  • 💚 Build #22890 succeeded f60d85fb42448be50065f01aebdf24c60dd9a6ff
  • 💚 Build #22861 succeeded c2dba8a2720b7216b48a025c0930e1e630b2ca22
  • 💚 Build #22816 succeeded e7782684c1d1ebbbaeaf7382e4c6808724258065

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@elastic elastic deleted a comment from kibanamachine Feb 6, 2020
@mshustov mshustov merged commit 5c3de3e into elastic:master Feb 7, 2020
jloleysens added a commit to jloleysens/kibana that referenced this pull request Feb 7, 2020
…b.com:jloleysens/kibana into console/feature/text-objects-in-saved-objects

* 'console/feature/text-objects-in-saved-objects' of github.com:jloleysens/kibana: (103 commits)
  fix auto closing new vis modal when navigating to lens or when navigating away with browser history (elastic#56998)
  TS of esKuery\node_types  (elastic#56857)
  Kibana app migration: Move static code dependencies into kibana_legacy plugin, part 1 (elastic#56408)
  Retry ES API calls that fail with 410/Gone (elastic#56950)
  [APM] Show missing permissions message to the user on the Services overview (elastic#56374)
  Fixing flaky CI tests for custom appRoutes (elastic#55763)
  [State Management][Docs] State syncing utils docs (elastic#56479)
  [Index management] Remove index mapper setting in tests (elastic#57066)
  Exposed common EuiExpressions to separate components be able to reuse for building new for Alert Types  (elastic#56466)
  [SIEM] update url state between page if date is relative (elastic#56813)
  fix for chart_types test (elastic#57056)
  chore(NA): remove compress from dll minimizer (elastic#57023)
  [File upload] Migrate routing to NP & add route validation (elastic#52313)
  Adding docs for grouped nav advanced setting (elastic#57013)
  Use i18n titles for field formatters, human names for numeral locales (elastic#56348)
  [Maps] Remove EMS catalogue url from docs (elastic#57020)
  [Endpoint] ERT-82 ERT-83 ERT-84: Alert list API with pagination (elastic#56538)
  [DOCS] Adds Apple notarization info to install doc (elastic#57042)
  [ML] New Platform server shim: update results service routes to use new platform router (elastic#56886)
  Fix typo on detection engine rule (elastic#56993)
  ...
@mshustov

This comment has been minimized.

@mshustov mshustov added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. bug Fixes for quality problems that affect the customer experience labels Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.7.0 v8.0.0
Projects
None yet
5 participants