Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] Adds ability to infer the newsfeed.enabled setting #56236

Merged
merged 6 commits into from
Jan 29, 2020
Merged

[SIEM] Adds ability to infer the newsfeed.enabled setting #56236

merged 6 commits into from
Jan 29, 2020

Commits on Jan 28, 2020

  1. Always return a contract from the newsfeed plugin 

    Without a contract, dependent plugins have no way of knowing whether the
plugin is enabled or not as the contract will always be undefined.
    @rylnd
    rylnd committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    fc49036 View commit details
    Browse the repository at this point in the history

  2. Export newsfeed contract types from public index 

    So that dependent plugins can use them.
    @rylnd
    rylnd committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    ecbd481 View commit details
    Browse the repository at this point in the history

  3. Declare newsfeed as an optional dependency of SIEM 

    We're going to use the availability of the newsfeed plugin as part of our
determination for whether or not to show the security newsfeed. If users
set `newsfeed.enabled: false`, the plugin will be unavailable and the
security feed will not be shown.
    @rylnd
    rylnd committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    ea9bbc9 View commit details
    Browse the repository at this point in the history

  4. Respect global newsfeed.enabled config in Security newsfeed 

    The presence of the newsfeed plugin means that newsfeed.enabled is true.
If both that and our local setting are true, we will show the Security
feed.
    @rylnd
    rylnd committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    5b6af2b View commit details
    Browse the repository at this point in the history

  5. Prefer object type over empty interface

    @rylnd
    rylnd committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    9749dc0 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into siem_newsfeed_setting

    @elasticmachine
    elasticmachine authored Jan 28, 2020
    Configuration menu
    Copy the full SHA
    91b05db View commit details
    Browse the repository at this point in the history