[SIEM] [Detections] Import rules #56389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XavierM
added
Team:SIEM
v8.0.0
release_note:skip
|
Pinging @elastic/siem (Team:SIEM) |
dhurley14
reviewed
Jan 30, 2020
x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/utils.ts
Outdated
Show resolved
Hide resolved
dhurley14
reviewed
Jan 30, 2020
x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/import_rules_route.ts
Show resolved
Hide resolved
dhurley14
approved these changes
Jan 30, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Found this bug, I think it can be a separate PR down the line. However the export was throwing some 500's. Might be worth porting that over to use Promise.all to bubble the error back up too here. |
dhurley14
reviewed
Jan 31, 2020
...gacy/plugins/siem/public/pages/detection_engine/rules/components/import_rule_modal/index.tsx
Show resolved
Hide resolved
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Jan 31, 2020
* refactor import rules to do it by batch * fix error msg on api to match with json contract * review I * fix export
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Jan 31, 2020
* refactor import rules to do it by batch * fix error msg on api to match with json contract * review I * fix export
XavierM
added a commit
that referenced
this pull request
Jan 31, 2020
XavierM
added a commit
that referenced
this pull request
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately