[Lens] Fix bugs in Lens filters #56441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wylieconlon
added
release_note:fix
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
I'm going to update this PR to fix another bug: #55603 |
wylieconlon
changed the title
|
@elasticmachine merge upstream |
timroes
approved these changes
Feb 3, 2020
|
Follow up issue: #56627 |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This was referenced Feb 3, 2020
wylieconlon
pushed a commit
to wylieconlon/kibana
that referenced
this pull request
Feb 3, 2020
* [Lens] Fix bug where filters were not displayed * Fix elastic#55603 Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
wylieconlon
pushed a commit
that referenced
this pull request
Feb 3, 2020
wylieconlon
pushed a commit
that referenced
this pull request
Feb 14, 2020
* [Lens] Fix bugs in Lens filters (#56441) * [Lens] Fix bug where filters were not displayed * Fix #55603 Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * Fix bugs * Update * Actually fix infinite loop due to referential equality * Update snapshot * Build filters explicitly Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note
Fixes bugs in Lens display of filters. When navigating to Lens from a dashboard, only pinned filters are used now. Also, when navigating to a previously-saved Lens visualization, Lens now shows all of the filters that were saved with the visualization. Now Lens is accurately showing all saved filters.
Notes
Fixes #54941 and fixes #55603
The bugs are caused by a change to the TopNav component, previously filters were displayed based on Lens's internal state, but now use the
filterManagercomponent. We did not write code to callsetAppFilterson the filter manager at the appropriate times.Steps to verify #55603:
Steps to verify #54941:
2. Refresh the page