-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitoring] Migrate server to NP #56675
Conversation
@elasticmachine merge upstream |
merge conflict between base and head |
💔 Build Failed
History
To update your PR or re-run it, just comment with: |
Pinging @elastic/stack-monitoring (Team:Monitoring) |
@elasticmachine merge upstream |
💔 Build Failed
History
To update your PR or re-run it, just comment with: |
@elasticmachine merge upstream |
merge conflict between base and head |
CI blocked by #56872 |
@chrisronline #57655 landed. you should be able to reuse elasticsearh config as import {ElasticsearchConfig} from 'src/core/server';
const config$ = config.create().pipe(map(rawConfig => new ElasticsearchConfig(rawConfig)));
const client$ = config$.pipe(map(config => elasticsearch.createClient('monitoring', config)); In this case, hosts will be wrapped in an array --> |
@chrisronline spotted the CI error from the ML job cloning test on this PR. If you haven't done so already, you probably want to rebase against master as we disabled this test yesterday whilst we work on a stability fix for the failing test. |
@elasticmachine merge upstream |
x-pack/plugins/monitoring/server/kibana_monitoring/collectors/get_ops_stats_collector.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/monitoring/server/kibana_monitoring/collectors/get_ops_stats_collector.ts
Outdated
Show resolved
Hide resolved
...ck/plugins/monitoring/server/lib/elasticsearch/nodes/get_nodes/__test__/get_node_ids.test.js
Outdated
Show resolved
Hide resolved
I’m kinda confused about why we still need x-pack/legacy/plugins/monitoring/config.js? Won't it be replaced by x-pack/plugins/monitoring/server/config.ts Or will it be gone when we do the complete cutover to NP? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job @chrisronline 🏆 🎉 💯 Loving the progressive Typescript take over 💝
Yea, it should be gone when we completely switch over. It's still there because the client side code reads from it too. |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Backport: 7.x: 8d9f39b |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
I did backport this @kibanamachine. You okay? |
This PR migrates the stack monitoring server code to the new platform!
TODO
Adopt core metrics service (once officially ready): Add core metrics service #58623