-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Make field stats work for index patterns without time fields #56759
Conversation
Pinging @elastic/kibana-app (Team:KibanaApp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not test, but this is almost identical to the change I did for the field existence endpoint.
The only thing you could add is a unit test to verify that the correct request is made from the client in this case.
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
…lastic#56759) * Fix field stats not loaded without time field * Add integration test for API * Add unit test for API call * Correct typo in comment
…lastic#56759) * Fix field stats not loaded without time field * Add integration test for API * Add unit test for API call * Correct typo in comment
Summary
Fix #55033
Currently Lens doesn't allow showing field stats for an index pattern without a time field (the request fail the validation, since no timeField parameter is passed).
This allows also requesting field stats without a timeField, so it will work for those index patterns.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately