Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Make field stats work for index patterns without time fields #56759

Merged
merged 5 commits into from
Feb 6, 2020

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Feb 4, 2020

Summary

Fix #55033

Currently Lens doesn't allow showing field stats for an index pattern without a time field (the request fail the validation, since no timeField parameter is passed).

This allows also requesting field stats without a timeField, so it will work for those index patterns.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@timroes timroes added release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 Feature:Lens v7.7.0 labels Feb 4, 2020
@timroes timroes requested review from wylieconlon, mbondyra and a team February 4, 2020 16:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test, but this is almost identical to the change I did for the field existence endpoint.

The only thing you could add is a unit test to verify that the correct request is made from the client in this case.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@timroes timroes merged commit ed2bac3 into elastic:master Feb 6, 2020
@timroes timroes deleted the lens/non-timefield-fieldstats branch February 6, 2020 11:21
timroes pushed a commit to timroes/kibana that referenced this pull request Feb 6, 2020
…lastic#56759)

* Fix field stats not loaded without time field

* Add integration test for API

* Add unit test for API call

* Correct typo in comment
timroes pushed a commit that referenced this pull request Feb 6, 2020
…56759) (#56963)

* Fix field stats not loaded without time field

* Add integration test for API

* Add unit test for API call

* Correct typo in comment
@timroes timroes added the v7.6.1 label Feb 12, 2020
timroes pushed a commit to timroes/kibana that referenced this pull request Feb 12, 2020
…lastic#56759)

* Fix field stats not loaded without time field

* Add integration test for API

* Add unit test for API call

* Correct typo in comment
timroes pushed a commit that referenced this pull request Feb 12, 2020
…56759) (#57503)

* Fix field stats not loaded without time field

* Add integration test for API

* Add unit test for API call

* Correct typo in comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.6.1 v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] Cannot load field data statistics for index patterns without timefield
4 participants