-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow duplicate percentiles (#57444) #58299
Disallow duplicate percentiles (#57444) #58299
Conversation
…allow duplicates. Enabled this option in the percentiles editor. Added unit / integration tests
Pinging @elastic/kibana-app (Team:KibanaApp) |
...plugins/vis_default_editor/public/components/controls/components/number_list/number_list.tsx
Outdated
Show resolved
Hide resolved
...y/core_plugins/vis_default_editor/public/components/controls/components/number_list/utils.ts
Outdated
Show resolved
Hide resolved
…method, updated tests to reflect change. Made Validate Ascending order default to false, and updated it to match in Percentiles and Percentile_ranks
…uplicatePercentile
...y/core_plugins/vis_default_editor/public/components/controls/components/number_list/utils.ts
Outdated
Show resolved
Hide resolved
...plugins/vis_default_editor/public/components/controls/components/number_list/number_list.tsx
Show resolved
Hide resolved
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Chrome Linux, works. Code LGTM
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
* master: (26 commits) [Endpoint] Alert Details Overview (elastic#58412) Service map language icons (elastic#58633) [SIEM] [Case] Comments to case view (elastic#58315) Remove appBasePath from docs + add mock for AppMountParameters (elastic#58775) [kbn/optimizer] fix ui/* url rewrites in dist (elastic#58627) Dashboard a11y tests (elastic#58122) Downgrade "setting up plugin" log to debug (elastic#58776) [CI] Pipeline refactoring (elastic#56447) [Advanced Settings] Fix a11y of unsaved indicator (elastic#58511) put params into short url instead of behind it (elastic#58846) show timepicker in timelion and tsvb (elastic#58857) improve graph missing workspace error message (elastic#58876) [Maps] direct Discover "visualize" to open Maps application (elastic#58549) Disallow duplicate percentiles (elastic#57444) (elastic#58299) removing references to visTypes uiExports (elastic#58337) [SIEM] Default the Timeline events filter to show All events (elastic#58953) [Remote clusters] Add indexManagement as required plugin (elastic#58915) [DOCS] Rework of main get started page (elastic#58260) [Endpoint] [Tests] fixes elastic#57946 flaky endpoint policy list test (elastic#58348) [Endpoint] add resolver middleware (elastic#58288) ...
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Added an optional validation step to the number_list component to disallow duplicates, Reworked and consolidated number_list component validations into one method and enabled this option in the percentiles editor. Added unit / integration tests
Summary
Added an option for disallowing duplicates in the number list component. Enabled this option in the percentiles editor. Closes #57444.
Checklist
Delete any items that are not applicable to this PR.
For maintainers