Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Redis Enterprise to home tutorial #59136

Merged
merged 1 commit into from
Mar 4, 2020

Conversation

mtojek
Copy link
Contributor

@mtojek mtojek commented Mar 3, 2020

Summary

This PR adds Redis Enterprise tile to Kibana home tutorial.

Zrzut ekranu 2020-03-3 o 13 51 01

Issue: elastic/beats#15269

@mtojek mtojek added release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 3, 2020
@mtojek mtojek requested a review from a team March 3, 2020 12:53
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293
Copy link
Contributor

@mtojek Did you add the kibana review manually? We've excluded the folders with the actual tutorials from the code ownership to make it possible for teams to merge in tutorials without going through the "Kibana app" review gates (mainly because we don't know much about the data sources added and whether everything is accurate).

So feel free to have this approved by someone at your team, no need to block on us. If this is to get a mandatory second pair of eyes on the change, we are happy to verify.

@mtojek
Copy link
Contributor Author

mtojek commented Mar 3, 2020

So feel free to have this approved by someone at your team, no need to block on us. If this is to get a mandatory second pair of eyes on the change, we are happy to verify.

Thanks, unmarking "kibana-app" and will reach out to beats team members.

@mtojek mtojek requested review from a team and removed request for a team March 3, 2020 15:08
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mtojek mtojek merged commit 3d06a62 into elastic:master Mar 4, 2020
mtojek added a commit to mtojek/kibana that referenced this pull request Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants