Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In scripted fields, unable to switch the Type - getting a console error which says - Class constructor DecoratedFieldFormat cannot be invoked without 'new' #59285

Merged
merged 4 commits into from
Mar 9, 2020
Merged

In scripted fields, unable to switch the Type - getting a console error which says - Class constructor DecoratedFieldFormat cannot be invoked without 'new' #59285

merged 4 commits into from
Mar 9, 2020

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Mar 4, 2020 •
edited
Loading

Closes: #58763

Summary

get_default_format.js:35 Uncaught TypeError: Class constructor DecoratedFieldFormat cannot be invoked without 'new'
    at new DefaultFormat (get_default_format.js:35)
    at FieldEditor.onTypeChange (field_editor.js:115)
    at onChange (field_editor.js:567)
    at HTMLUnknownElement.callCallback (react-dom.development.js:336)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:385)
    at invokeGuardedCallback (react-dom.development.js:440)
    at invokeGuardedCallbackAndCatchFirstError (react-dom.development.js:454)
    at executeDispatch (react-dom.development.js:584)
    at executeDispatchesInOrder (react-dom.development.js:609)
    at executeDispatchesAndRelease (react-dom.development.js:713)

Screen Shot 2020-02-27 at 9 59 04 AM

Checklist

Delete any items that are not applicable to this PR.

For maintainers

alexwizp added 2 commits March 4, 2020 14:13
@alexwizp
In scripted fields, unable to switch the Type - getting a console e…
c07ac5c 
…rror which says - Class constructor DecoratedFieldFormat cannot be invoked without 'new'

Closes: elastic#58763
@alexwizp
Merge remote-tracking branch 'upstream/master' into 58763
96910bc
@alexwizp alexwizp self-assigned this Mar 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@alexwizp alexwizp requested a review from dmlemeshko March 4, 2020 11:16
@alexwizp alexwizp marked this pull request as ready for review March 4, 2020 11:17
dmlemeshko
dmlemeshko reviewed Mar 4, 2020
View reviewed changes
Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to successfully run the scripted field test suite with instrumented Kibana (code coverage collection) and may confirm the issue is fixed for that use case.
No code review from my side :)

@alexwizp alexwizp added the review label Mar 5, 2020
@alexwizp
Copy link
Contributor Author

alexwizp commented Mar 5, 2020

@elasticmachine merge upstream

@alexwizp
Copy link
Contributor Author

alexwizp commented Mar 8, 2020

@elasticmachine merge upstream

1 similar comment
@alexwizp
Copy link
Contributor Author

alexwizp commented Mar 9, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

lizozom
lizozom approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checkout and tested - issue is resolved
LGTM

@alexwizp alexwizp merged commit f0e063c into elastic:master Mar 9, 2020
@alexwizp alexwizp mentioned this pull request Mar 9, 2020
Merged
alexwizp added a commit to alexwizp/kibana that referenced this pull request Mar 9, 2020
@alexwizp @elasticmachine
In scripted fields, unable to switch the Type - getting a console e…
06e48d4 
…rror which says - Class constructor DecoratedFieldFormat cannot be invoked without 'new' (elastic#59285)

Closes: elastic#58763

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
alexwizp added a commit that referenced this pull request Mar 9, 2020
@alexwizp @elasticmachine
In scripted fields, unable to switch the Type - getting a console e…
07752c8 
…rror which says - Class constructor DecoratedFieldFormat cannot be invoked without 'new' (#59285) (#59640)

Closes: #58763

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 10, 2020
@gmmorris
Merge branch 'master' into alerting/view-in-app
0363764 
* master: (22 commits)
  Generate docs from data plugin (elastic#56955)
  Fixes elastic#59513 by hiding one of the symmetric edges rather than omiting it (elastic#59514)
  Harden creation of child processes (elastic#55697)
  [Alerting] replace watcher http APIs used by index threshold Alerting (elastic#59475)
  [Maps][docs] add more details to Quantitative data driven styling docs (elastic#59553)
  chore: 🤖 hide Drilldowns in master (elastic#59698)
  [Discover] Migrate AppState/GlobalState to new app state helpers (elastic#57175)
  Use HTTP request schemas to create types, use those types in the client (elastic#59340)
  [Maps] Support categorical styling for numbers and dates (elastic#57908)
  [ML] Functional API tests - bucket span estimation with custom search.max_buckets (elastic#59665)
  Fix slm_ui setting by changing camel case back to snake case. (elastic#59663)
  removes beta tag (elastic#59618)
  [DOCS] Removed spatial references (elastic#59595)
  fix outdated docs (elastic#58729)
  [ML] Fixes bucket span estimators loading of max_buckets setting (elastic#59639)
  [ML] Refactoring anomaly detector job types (elastic#59556)
  [Upgrade Assistant] Better handling of closed indices (elastic#58890)
  additional visualizations plugin cleanup before moving to NP (elastic#59318)
  In scripted fields, unable to switch the `Type` - getting a console error which says - Class constructor DecoratedFieldFormat cannot be invoked without 'new' (elastic#59285)
  [Visualize] Remove global state in visualize (elastic#58352)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 10, 2020
@gmmorris
Merge branch 'alerting/fix-flaky-instance-test' of github.com:gmmorri…
ea98883 
…s/kibana into alerting/fix-flaky-instance-test

* 'alerting/fix-flaky-instance-test' of github.com:gmmorris/kibana: (176 commits)
  Generate docs from data plugin (elastic#56955)
  Fixes elastic#59513 by hiding one of the symmetric edges rather than omiting it (elastic#59514)
  Harden creation of child processes (elastic#55697)
  [Alerting] replace watcher http APIs used by index threshold Alerting (elastic#59475)
  [Maps][docs] add more details to Quantitative data driven styling docs (elastic#59553)
  chore: 🤖 hide Drilldowns in master (elastic#59698)
  [Discover] Migrate AppState/GlobalState to new app state helpers (elastic#57175)
  Use HTTP request schemas to create types, use those types in the client (elastic#59340)
  [Maps] Support categorical styling for numbers and dates (elastic#57908)
  [ML] Functional API tests - bucket span estimation with custom search.max_buckets (elastic#59665)
  Fix slm_ui setting by changing camel case back to snake case. (elastic#59663)
  removes beta tag (elastic#59618)
  [DOCS] Removed spatial references (elastic#59595)
  fix outdated docs (elastic#58729)
  [ML] Fixes bucket span estimators loading of max_buckets setting (elastic#59639)
  [ML] Refactoring anomaly detector job types (elastic#59556)
  [Upgrade Assistant] Better handling of closed indices (elastic#58890)
  additional visualizations plugin cleanup before moving to NP (elastic#59318)
  In scripted fields, unable to switch the `Type` - getting a console error which says - Class constructor DecoratedFieldFormat cannot be invoked without 'new' (elastic#59285)
  [Visualize] Remove global state in visualize (elastic#58352)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmlemeshko dmlemeshko dmlemeshko left review comments

@lizozom lizozom lizozom approved these changes

@lukeelmers lukeelmers Awaiting requested review from lukeelmers

@ppisljar ppisljar Awaiting requested review from ppisljar

Assignees

@alexwizp alexwizp

Labels
Feature:FieldFormatters release_note:fix review v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
5 participants
@alexwizp @elasticmachine @kibanamachine @lizozom @dmlemeshko