Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pluginApi] expose support flags #5941

Closed

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Jan 19, 2016

With #5871 we removed support for configuration-based autoloading and moved to require-based autoloading. This change is difficult for plugin authors to transition through in a backwards compatible way so I thought it would make sense to start helping plugin authors know which features are/are not available to them with a simple collection of "supports" flags. For now it just shows that autoload: false, so that plugins can expose an alternate main file which includes the autoloads they require.

With elastic#5871 we removed support for configuration-based autoloading and moved to require-based autoloading. This change is difficult for plugin authors to make in a backwards compatible way so I thought
it would make sense to start helping plugin authors know which features are/are not available to them with a simple collection of "supports" flags. For now it just shows that `autoload: false`, so that
plugins can expose an alternate main file which includes the autoloads they require
@rashidkpc
Copy link
Contributor

From IRC:

15:14 < rashidkpc> spalger: hmm, ok this basically just makes feature detection easier
15:15 < rashidkpc> spalger: do we want to set this precedent though? That list will get nasty eventually
15:15 < rashidkpc> tbh, I get that detecting support for autoloading is gross right now
15:15 < rashidkpc> but i dunno if you want to go this route

@spalger
Copy link
Contributor Author

spalger commented Jan 19, 2016

Meh, I agree, this is gross

@spalger spalger closed this Jan 19, 2016
@spalger spalger deleted the implement/pluginApiSupportFlags branch February 25, 2016 22:52
@tbragin tbragin removed the v5.0.0 label Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants