[skip-ci] Service Status RFC #59621
Merged
[skip-ci] Service Status RFC #59621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdover
added
Team:Core
|
Pinging @elastic/kibana-platform (Team:Platform) |
joshdover
force-pushed
the
rfc/service-status
branch
from
c6c5534 to
497ff50
Compare
joshdover
commented
Mar 9, 2020
pgayvallet
reviewed
Mar 9, 2020
legrego
reviewed
Mar 9, 2020
mshustov
approved these changes
Mar 11, 2020
- Add clarity about which Core services are included in `CoreStatus` - Add JSON-serializable types for `meta` property - Add overall status calculation section - Add note that some plugin contract APIs may throw - Add `self` argument to `unavailableWhen` utility - Remove unresolved questions that have been addressed
|
Moving a little aggressively on this one, but I'm going to go ahead and put this RFC in the final comment period. If there are any fundamental issues with this proposal, please raise ASAP. If no fundamental problems are found, this RFC will be accepted and merged on Monday, March 16. |
joshdover
added
the
RFC/final-comment-period
lukeelmers
approved these changes
Mar 11, 2020
rudolf
reviewed
Mar 12, 2020
sorenlouv
reviewed
Mar 12, 2020
rudolf
approved these changes
Mar 16, 2020
This was referenced Mar 16, 2020
pgayvallet
approved these changes
Mar 16, 2020
| /** | ||
| * The current availability level of the service. | ||
| */ | ||
| level: ServiceStatusLevel.available; |
There was a problem hiding this comment.
Shouldn't that be just ServiceStatusLevel ?
There was a problem hiding this comment.
This union type is to express that when level is not available, the summary field is required. This first part of the union is the case where it is not required.
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
RFC for #41983
View rendered