Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[App Arch] migrate legacy CSS to new platform (core_plugins/kibana_react) #59882

Merged
merged 13 commits into from
Mar 24, 2020
Merged

[App Arch] migrate legacy CSS to new platform (core_plugins/kibana_react) #59882

merged 13 commits into from
Mar 24, 2020

Conversation

VladLasitsa
Copy link
Contributor

@VladLasitsa VladLasitsa commented Mar 11, 2020 •
edited by alexwizp
Loading

Part of: #55493

Summary

Here's a list of app arch legacy items I've found so far which contain some scss (be sure to look around for anything I may have missed):

  • core_plugins/kibana_react

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@VladLasitsa VladLasitsa self-assigned this Mar 11, 2020
@VladLasitsa VladLasitsa requested a review from alexwizp March 11, 2020 10:49
@alexwizp
Copy link
Contributor

@elasticmachine merge upstream

@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

alexwizp
alexwizp reviewed Mar 12, 2020
View reviewed changes
src/plugins/kibana_react/public/index.ts Outdated
@@ -25,7 +25,7 @@ export * from './ui_settings';
export * from './field_icon';
export * from './table_list_view';
export * from './split_panel';
export { Markdown, MarkdownSimple } from './markdown';
export * from './markdown';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert { Markdown, MarkdownSimple }. We are trying to don't use *

@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

@alexwizp
Copy link
Contributor

ci is red due to:
image

@alexwizp alexwizp changed the title [App Arch] migrate legacy CSS to new platform [App Arch] migrate legacy CSS to new platform (core_plugins/kibana_react) Mar 16, 2020
@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

@spalger spalger mentioned this pull request Mar 19, 2020
Merged
@spalger
Copy link
Contributor

spalger commented Mar 20, 2020

@elasticmachine merge upstream

@alexwizp alexwizp self-requested a review March 20, 2020 07:59
@VladLasitsa VladLasitsa added Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes Team:AppArch v7.7.0 labels Mar 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

alexwizp
alexwizp reviewed Mar 20, 2020
View reviewed changes
Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexwizp alexwizp marked this pull request as ready for review March 20, 2020 08:20
@alexwizp alexwizp requested a review from a team March 20, 2020 08:20
@alexwizp alexwizp requested review from a team as code owners March 20, 2020 08:20
alexwizp
alexwizp requested changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we still import Markdown/MarkdownSimple from the /../kibana_react/public' folder
At least I found one place with that wrong import. see: src/legacy/core_plugins/vis_type_timeseries/public/components/vis_types/markdown/vis.js

alexwizp
alexwizp approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was wrong 😄 Code LGTM!

poffdeluxe
poffdeluxe approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Canvas changes work great!

cchaos
cchaos approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SASS file moves LGTM, so long as the plugin is correctly building compiling the CSS.

@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

lizozom
lizozom approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kertal
kertal approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KibanaApp Codeowner file LGTM!

@VladLasitsa VladLasitsa merged commit c26493d into elastic:master Mar 24, 2020
@VladLasitsa VladLasitsa mentioned this pull request Mar 24, 2020
Merged
VladLasitsa added a commit to VladLasitsa/kibana that referenced this pull request Mar 24, 2020
@VladLasitsa @elasticmachine
[App Arch] migrate legacy CSS to new platform (core_plugins/kibana_re…
fe20efc 
…act) (elastic#59882)

* Migrate markdown styles to the new platform

* Removed unused import

* Update index.ts

* Removed not need layer

* Fixed paths

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 24, 2020
@gmmorris
Merge branch 'master' into alerting/tls-warning
1b3d0b4 
* master: (34 commits)
  [APM] add service map config options to legacy plugin (elastic#61002)
  [App Arch] migrate legacy CSS to new platform (core_plugins/kibana_react) (elastic#59882)
  Migrated styles for "share" plugin to new platform (elastic#59981)
  [ML] Module setup with dynamic model memory estimation (elastic#60656)
  Drilldowns (elastic#59632)
  Upgrade mocha dev-dependency from 6.2.2 to 7.1.1 (elastic#60779)
  [SIEM] Overview: Recent cases widget (elastic#60993)
  [ML] Functional tests - stabilize df analytics clone tests (elastic#60497)
  [SIEM] Updates process and TLS tables to use ECS 1.5 fields (elastic#60854)
  Migrate doc view part of discover (elastic#58094)
  Revert "[APM] Collect telemetry about data/API performance (elastic#51612)"
  fix(NA): log rotation watchers usage (elastic#60956)
  [SIEM] [CASES] Build lego blocks case details view (elastic#60864)
  Create Painless Lab app (elastic#57538)
  [SIEM] Move Timeline Template field to first step of rule creation (elastic#60840)
  [Reporting/New Platform Migration] Use a new config service on server-side (elastic#55882)
  [Alerting] allow email action to not require auth (elastic#60839)
  [Maps] Default ES document layer scaling type to clusters and show scaling UI in the create wizard (elastic#60668)
  [APM] Collect telemetry about data/API performance (elastic#51612)
  Implement Kibana Login Selector (elastic#53010)
  ...
VladLasitsa added a commit that referenced this pull request Mar 25, 2020
@VladLasitsa @elasticmachine
[App Arch] migrate legacy CSS to new platform (core_plugins/kibana_re…
95688c7 
…act) (#59882) (#61039)

* Migrate markdown styles to the new platform

* Removed unused import

* Update index.ts

* Removed not need layer

* Fixed paths

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@lukeelmers lukeelmers mentioned this pull request Mar 26, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexwizp alexwizp alexwizp approved these changes

@lizozom lizozom lizozom approved these changes

@poffdeluxe poffdeluxe poffdeluxe approved these changes

@cchaos cchaos cchaos approved these changes

@kertal kertal kertal approved these changes

Assignees

@VladLasitsa VladLasitsa

Labels
Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@VladLasitsa @alexwizp @spalger @elasticmachine @kibanamachine @kertal @cchaos @poffdeluxe @lizozom