Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: 🎡 add more tags to ProBot PR path labeler #59913

Merged
merged 3 commits into from
Mar 25, 2020
Merged

ci: 🎡 add more tags to ProBot PR path labeler #59913

merged 3 commits into from
Mar 25, 2020

Conversation

streamich
Copy link
Contributor

Summary

Add more tags to ProBot PR path labeler.

@streamich streamich added release_note:skip Skip the PR/issue when compiling release notes review Team:AppArch v8.0.0 labels Mar 11, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates here LGTM! In particular I think it'll be nice to have an AppArch team label by default on items that we are doing codeowners reviews on, that way we can track those in the team GH project.

The only thing I'm wondering is whether it will cause confusion in the future if, for example, something changes a tiny piece of one of our plugins (like an import), and a feature label is applied even though the PR doesn't truly affect that feature. But I think the only way to determine this is to give it a go!

We can also revisit the paths included here when doing other plugin cleanup taks in #55919 and adjust settings accordingly.

@kibanamachine
Copy link
Contributor

💔 Build Failed


Test Failures

Kibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/plugins/index_management/__jest__/client_integration. on component mount review (step 5) should render a warning message if a wildcard is used as an index pattern

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 3 times on tracked branches: https://github.com/elastic/kibana/issues/59859


Stack Trace

TypeError: Cannot read property 'data' of undefined
    at getData (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/index_management/public/application/components/mappings_editor/mappings_state.tsx:120:50)
    at setDataGetter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/index_management/public/application/components/template_form/steps/step_mappings.tsx:33:22)

Kibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/plugins/index_management/__jest__/client_integration. on component mount form payload & api errors should surface the API errors from the put HTTP request

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/59869


Stack Trace

Error: Method “simulate” is meant to be run on 1 node. 0 found instead.
    at ReactWrapper.single (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/enzyme/src/ReactWrapper.js:1168:13)
    at ReactWrapper.simulate (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/enzyme/src/ReactWrapper.js:665:17)
    at Object.completeStepFour (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/index_management/__jest__/client_integration/helpers/template_form.helpers.ts:133:30)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/index_management/__jest__/client_integration/template_create.test.tsx:235:25

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@streamich
Copy link
Contributor Author

@elasticmachine merge upstream

@streamich
Copy link
Contributor Author

The only thing I'm wondering is whether it will cause confusion in the future if, for example, something changes a tiny piece of one of our plugins (like an import), and a feature label is applied even though the PR doesn't truly affect that feature.

If it causes confusion I'm happy to adjust paths accordingly or remove the labeler.

We can also revisit the paths included here when doing other plugin cleanup taks in #55919 and adjust settings accordingly.

I see you added it as a task there 👍

@streamich streamich merged commit 420c213 into elastic:master Mar 25, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 59913 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 27, 2020
@streamich streamich added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes review v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants