-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: 🎡 add more tags to ProBot PR path labeler #59913
Conversation
Pinging @elastic/kibana-app-arch (Team:AppArch) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates here LGTM! In particular I think it'll be nice to have an AppArch team label by default on items that we are doing codeowners reviews on, that way we can track those in the team GH project.
The only thing I'm wondering is whether it will cause confusion in the future if, for example, something changes a tiny piece of one of our plugins (like an import), and a feature label is applied even though the PR doesn't truly affect that feature. But I think the only way to determine this is to give it a go!
We can also revisit the paths included here when doing other plugin cleanup taks in #55919 and adjust settings accordingly.
💔 Build FailedTest FailuresKibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/plugins/index_management/__jest__/client_integration. on component mount review (step 5) should render a warning message if a wildcard is used as an index patternStandard Out
Stack Trace
Kibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/plugins/index_management/__jest__/client_integration. on component mount form payload & api errors should surface the API errors from the put HTTP requestStandard Out
Stack Trace
To update your PR or re-run it, just comment with: |
@elasticmachine merge upstream |
If it causes confusion I'm happy to adjust paths accordingly or remove the labeler.
I see you added it as a task there 👍 |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Summary
Add more tags to ProBot PR path labeler.