Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remote clusters] Update copy #60382

Merged
merged 4 commits into from
Mar 19, 2020
Merged

[Remote clusters] Update copy #60382

merged 4 commits into from
Mar 19, 2020

Conversation

alisonelizabeth
Copy link
Contributor

This PR updates copy in the remote clusters UI.

Related to #59221

Screenshots

Screen Shot 2020-03-17 at 10 41 19 AM

Screen Shot 2020-03-17 at 10 41 35 AM

Screen Shot 2020-03-17 at 10 42 08 AM

@alisonelizabeth alisonelizabeth added release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.7.0 v8.0.0 labels Mar 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@alisonelizabeth alisonelizabeth requested a review from gchaps March 17, 2020 14:49
gchaps
gchaps reviewed Mar 17, 2020
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intro sentence

Add a remote cluster that connects to seed nodes or a single proxy request.

Proxy address

The address to use for remote connections.

Node connections

The number of gateway nodes to use for requests. (Not sure about this, but want to get away from ending with the word "to")

Tooltip:

Edit this cluster to update the deprecated settings.

Server name (optional)

  • Add optional to label
  • Would it be good to include an example as placeholder text
  • Label is server name but talks about hostname
  • Let's discuss some ways to reduce the text

@alisonelizabeth
Copy link
Contributor Author

alisonelizabeth commented Mar 18, 2020 •
edited
Loading

@gchaps thanks for the review! I've updated the copy per your suggestions in 4d28412.

The number of gateway nodes to use for requests. (Not sure about this, but want to get away from ending with the word "to")

I changed this to: "The number of gateway nodes to connect to for this cluster." WDYT?

Server name (optional)
Add optional to label
Would it be good to include an example as placeholder text
Label is server name but talks about hostname
Let's discuss some ways to reduce the text

I added (optional) to the label. I also shortened the text a little bit, but could probably still be improved. Here is the ES documentation on it: https://www.elastic.co/guide/en/elasticsearch/reference/master/modules-remote-clusters.html#remote-cluster-proxy-settings. What do you think about linking to this in the help text?

@gchaps
Copy link
Contributor

gchaps commented Mar 18, 2020

Good suggestions, @alisonelizabeth.

I like this text:

The number of gateway nodes to connect to for this cluster.

I shortened this text a bit and added the "Learn more" link.

A string sent in the server_name field of the TLS Server Name Indication extension if TLS is enabled. Learn more.

gchaps
gchaps approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alisonelizabeth alisonelizabeth merged commit ee6bb64 into elastic:master Mar 19, 2020
@alisonelizabeth alisonelizabeth deleted the remote_clusters/copy-changes branch March 19, 2020 12:23
alisonelizabeth added a commit to alisonelizabeth/kibana that referenced this pull request Mar 19, 2020
@alisonelizabeth
[Remote clusters] Update copy (elastic#60382)
329fc19
@alisonelizabeth alisonelizabeth mentioned this pull request Mar 19, 2020
Merged
jloleysens added a commit to jloleysens/kibana that referenced this pull request Mar 19, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into refactor/cons…
3c1d020 
…ole/cleanup

* 'master' of github.com:elastic/kibana: (47 commits)
  [Remote clusters] Update copy (elastic#60382)
  Sort by name when fetching alerts and connectors (elastic#60506)
  Make slack param validation handle empty messages (elastic#60468)
  [Alerting] Adds navigation by consumer and alert type to alerting (elastic#58997)
  Introduce search interceptor (elastic#60523)
  [ML] Add functional tests for file data visualizer (elastic#60413)
  [APM] Optimize service map query (elastic#60412)
  [SIEM][Detection Engine] Adds lists feature flag and list values to the REST interfaces
  Enhancement/update esdocs datasource (elastic#59512)
  [junit] only include stdout in report for failures (elastic#60530)
  Update dependency nock to v12 (elastic#60422)
  upgrade execa to get stdout/stderr in error messages (elastic#60537)
  skip flaky suite (elastic#60471)
  [Ingest] Agent Config Details - Data sources list ui (elastic#60429)
  [SIEM] Create ML Rules (elastic#58053)
  skip flaky suite (elastic#60559)
  fix agent type (elastic#60554)
  Fixed default message for index threshold includes both threshold values (elastic#60545)
  [Ingest] Add support for `yaml` field types (elastic#60440)
  Solved the issue for a GROUP BY expression validation (elastic#60558)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 19, 2020
@gmmorris
Merge branch 'master' into alerting/tls-warning
18dc4ee 
* master: (39 commits)
  [SIEM][CASE]  Configuration page action bar (elastic#60608)
  [Remote clusters] Update copy (elastic#60382)
  Sort by name when fetching alerts and connectors (elastic#60506)
  Make slack param validation handle empty messages (elastic#60468)
  [Alerting] Adds navigation by consumer and alert type to alerting (elastic#58997)
  Introduce search interceptor (elastic#60523)
  [ML] Add functional tests for file data visualizer (elastic#60413)
  [APM] Optimize service map query (elastic#60412)
  [SIEM][Detection Engine] Adds lists feature flag and list values to the REST interfaces
  Enhancement/update esdocs datasource (elastic#59512)
  [junit] only include stdout in report for failures (elastic#60530)
  Update dependency nock to v12 (elastic#60422)
  upgrade execa to get stdout/stderr in error messages (elastic#60537)
  skip flaky suite (elastic#60471)
  [Ingest] Agent Config Details - Data sources list ui (elastic#60429)
  [SIEM] Create ML Rules (elastic#58053)
  skip flaky suite (elastic#60559)
  fix agent type (elastic#60554)
  Fixed default message for index threshold includes both threshold values (elastic#60545)
  [Ingest] Add support for `yaml` field types (elastic#60440)
  ...
alisonelizabeth added a commit that referenced this pull request Mar 19, 2020
@alisonelizabeth
[Remote clusters] Update copy (#60382) (#60618)
b3ba58f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchaps gchaps gchaps approved these changes

Assignees
No one assigned
Labels
Feature:CCR and Remote Clusters release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alisonelizabeth @elasticmachine @gchaps @kibanamachine