Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move visualizations plugin to new platform #60403

Merged
merged 27 commits into from
Mar 27, 2020
Merged

move visualizations plugin to new platform #60403

merged 27 commits into from
Mar 27, 2020

Conversation

ppisljar
Copy link
Member

@ppisljar ppisljar commented Mar 17, 2020 •
edited
Loading

Summary

Moves visualizations plugin over to new platform

@ppisljar ppisljar added release_note:skip Skip the PR/issue when compiling release notes Team:AppArch v7.7.0 v8.0.0 labels Mar 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@ppisljar ppisljar force-pushed the np/visualizations branch 2 times, most recently from 5565f6c to ab81927 Compare March 23, 2020 18:31
@ppisljar ppisljar marked this pull request as ready for review March 23, 2020 18:32
@ppisljar ppisljar requested a review from a team March 23, 2020 18:32
@ppisljar ppisljar requested review from a team as code owners March 23, 2020 18:32
@lukeelmers lukeelmers self-requested a review March 23, 2020 19:30
@thomasneirynck thomasneirynck self-requested a review March 23, 2020 20:03
snide
snide approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sass changes are just file moves. Didn't test functionality.

@ppisljar ppisljar requested a review from a team as a code owner March 23, 2020 21:25
kindsun
kindsun approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@kindsun kindsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

legacy maps changes lgtm w/ green CI!

  • code review
  • tested locally in chrome

ppisljar added 3 commits March 25, 2020 10:32
@ppisljar
typescripting vis_types
719bac7
@ppisljar
moving vis test to jest
bdca8d3
@ppisljar
Merge branch 'master' into np/visualizations
8f2f55b 
# Conflicts:
#	src/legacy/core_plugins/vis_type_metric/public/components/metric_vis_component.test.tsx
#	src/legacy/core_plugins/vis_type_metric/public/components/metric_vis_component.tsx
#	src/legacy/core_plugins/vis_type_metric/public/metric_vis_type.test.ts
#	src/legacy/core_plugins/vis_type_tagcloud/public/services.ts
#	src/legacy/core_plugins/vis_type_vislib/public/legacy.ts
#	src/legacy/core_plugins/vis_type_vislib/public/legacy_imports.ts
#	src/plugins/visualizations/public/embeddable/visualize_embeddable.ts
#	x-pack/legacy/plugins/lens/public/legacy_imports.ts
#	x-pack/legacy/plugins/lens/public/xy_visualization/xy_expression.tsx
@sulemanof
Copy link
Contributor

I don't know whether that's expected or not, but I just switched to this branch from current master (with installed sample data) and the Kibana server crashes with

 FATAL  Error: Document "e1d0f010-9ee7-11e7-8711-e7a007dcef99" has property "visualization" which belongs to a more recent version of Kibana (7.4.2).

I could confirm that this reproduces for me on master, so this is an issue (wasn't caused by this PR)

@ppisljar ppisljar removed the request for review from thomasneirynck March 26, 2020 06:34
@ppisljar ppisljar force-pushed the np/visualizations branch from 44b73bc to 0da04d0 Compare March 26, 2020 09:50
ppisljar added 2 commits March 26, 2020 03:30
@ppisljar
Merge branch 'master' into np/visualizations
200eec8 
# Conflicts:
#	src/legacy/core_plugins/vis_type_vislib/public/legacy.ts
#	src/legacy/core_plugins/vis_type_vislib/public/plugin.ts
@ppisljar
more fixes
3489bf6
@ppisljar
Copy link
Member Author

@elasticmachine merge upstream

flash1293
flash1293 approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kibana app changes LGTM 👍

src/legacy/core_plugins/vis_type_tagcloud/public/services.ts
@@ -23,3 +23,5 @@ import { DataPublicPluginStart } from '../../../../plugins/data/public';
export const [getFormatService, setFormatService] = createGetterSetter<
DataPublicPluginStart['fieldFormats']
>('data.fieldFormats');

export { npStart } from 'ui/new_platform';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be unused

@alexwizp
Copy link
Contributor 

Looks mostly good to me, left a few comments.

I don't know whether that's expected or not, but I just switched to this branch from current master (with installed sample data) and the Kibana server crashes with

 FATAL  Error: Document "e1d0f010-9ee7-11e7-8711-e7a007dcef99" has property "visualization" which belongs to a more recent version of Kibana (7.4.2).

@pgayvallet could this be related to #59291 or #59044 ? I cannot reproduce it locally, but @flash1293 is not only one who faced with that issue

@ppisljar ppisljar force-pushed the np/visualizations branch from 0a6fe0d to 5ed93d4 Compare March 27, 2020 07:08
ppisljar added 2 commits March 27, 2020 00:10
@ppisljar
Merge branch 'master' into np/visualizations
cfcb8f0 
# Conflicts:
#	src/legacy/ui/public/new_platform/__mocks__/helpers.ts
#	src/legacy/ui/public/new_platform/new_platform.ts
#	x-pack/legacy/plugins/canvas/canvas_plugin_src/expression_types/embeddable_types.ts
@ppisljar
Merge branch 'master' into np/visualizations
72cedba 
# Conflicts:
#	src/legacy/ui/public/new_platform/new_platform.karma_mock.js
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ppisljar ppisljar merged commit 7b0c66f into elastic:master Mar 27, 2020
@ppisljar ppisljar mentioned this pull request Mar 27, 2020
Closed
ppisljar added a commit to ppisljar/kibana that referenced this pull request Mar 28, 2020
@ppisljar
move visualizations plugin to new platform (elastic#60403)
dc7f1a6
@ppisljar ppisljar mentioned this pull request Mar 28, 2020
Merged
ppisljar added a commit to ppisljar/kibana that referenced this pull request Mar 28, 2020
@ppisljar
move visualizations plugin to new platform (elastic#60403)
0d3e2c0
@ppisljar ppisljar added v7.8.0 and removed v7.7.0 labels Mar 28, 2020
ppisljar added a commit that referenced this pull request Mar 28, 2020
@ppisljar
move visualizations plugin to new platform (#60403) (#61717)
b9318aa
@lukeelmers lukeelmers mentioned this pull request Mar 30, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeelmers lukeelmers lukeelmers left review comments

@kindsun kindsun kindsun approved these changes

@cqliu1 cqliu1 cqliu1 approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@flash1293 flash1293 flash1293 approved these changes

@snide snide snide approved these changes

Assignees
No one assigned
Labels
Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.