Migrate savedObjectManagementActionRegistry to NP plugin #60481
Conversation
pgayvallet
changed the title
pgayvallet
added
Feature:New Platform
Team:Core
|
Pinging @elastic/kibana-platform (Team:Platform) |
pgayvallet
added
release_note:skip
| // eslint-disable-next-line @kbn/eslint/no-restricted-paths | ||
| import { homePluginMock } from '../../home/public/mocks'; |
There was a problem hiding this comment.
home/public/mocks is a folder, it seems to break out eslint rule, and I was forced to eslint-disable
| export interface SavedObjectsManagementRecordReference { | ||
| type: string; | ||
| id: string; | ||
| name: string; | ||
| } |
There was a problem hiding this comment.
Duplicate of SavedObjectReference, removed it.
| "optionalPlugins": [ | ||
| "advancedSettings", | ||
| "home", | ||
| "management", | ||
| "security", | ||
| "usageCollection", | ||
| "savedObjectsManagement" | ||
| ], |
There was a problem hiding this comment.
My guess is that this dependency should be optional. @elastic/kibana-security tell me if this should move to required.
There was a problem hiding this comment.
You're absolutely right, we should make this an optional dependency
| notificationsSetup: core.notifications, | ||
| }); | ||
| }, | ||
| registerLegacyAPI: (legacyAPI: LegacyAPI) => {}, |
There was a problem hiding this comment.
@elastic/kibana-security As I said on slack, this is now an empty function. Should I remove it and associated legacy call, or do you want to keep it in case of?
There was a problem hiding this comment.
Yes, if you're able to easily remove this, then please do so. If it becomes too much, I'll happily to it in a followup PR
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
Should CODEOWNERS be updated to give this plugin an owner?
There was a problem hiding this comment.
Good catch. updated
…gement-action-registry
…gement-action-registry
…gement-action-registry
|
LGTM once |
…gement-action-registry
|
@elasticmachine merge upstream |
…gement-action-registry
src/plugins/saved_objects_management/public/services/action_registry.test.ts
Outdated
Show resolved
Hide resolved
…gement-action-registry
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
* create empty plugin + move home feature registration to it * move the so action_registry to new plugin * adapt existing calls to the registry * fix i18n namespace * fix table unit tests * update codeowners * rename plugin to match other PRs * remove registerLegacyAPI from spaces public plugin * fix typo Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
…1492) * create empty plugin + move home feature registration to it * move the so action_registry to new plugin * adapt existing calls to the registry * fix i18n namespace * fix table unit tests * update codeowners * rename plugin to match other PRs * remove registerLegacyAPI from spaces public plugin * fix typo Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Summary
Part of #50308
Migrate the savedObjects management actions registry to the new
SavedObjectsManagementplugin and adapt existing calls.Checklist