[SIEM] ML Rules Details #61182
Merged
[SIEM] ML Rules Details #61182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't display the row as fullwidth, lest the help text wrap across the entire page. It only looks okay now because it was a short sentence; adding the ML Job select with its wrapped text caused some visual weirdness, so this at least makes it consistent.
This is displayed both on the readonly form view, and the Rule Details page.
This is a base hook that we can combine with our permissions helpers.
If we're auto-activating jobs on their behalf, they'll need to be an admin.
This adds the auditMessage as well as a link to ML; actual status is next
Also simplifies the layout of these job details.
UseSiemJobs uses uiSettings, so we need to use our kibana mocks here.
rylnd
added
Team:SIEM
v8.0.0
release_note:skip
|
Pinging @elastic/siem (Team:SIEM) |
rylnd
commented
Mar 24, 2020
| [] | ||
| ); | ||
| const listItems = keys.reduce((acc: ListItems[], key: string) => { | ||
| if (key === 'machineLearningJobId') { |
There was a problem hiding this comment.
I added this branch here because I didn't want to add yet another optional argument to buildListItems that would only be used in one case.
spong
reviewed
Mar 24, 2020
|
|
||
| import { isJobStarted, isJobLoading, isJobFailed } from './'; | ||
|
|
||
| describe('isJobStarted', () => { |
There was a problem hiding this comment.
Yaaay! Tests for verifying job states -- thanks @rylnd! 🎉🥇
spong
reviewed
Mar 24, 2020
| @@ -101,6 +102,7 @@ export interface MlSetupArgs { | |||
| * Representation of an ML Job as returned from the `ml/jobs/jobs_summary` API | |||
| */ | |||
| export interface JobSummary { | |||
| auditMessage?: AuditMessageBase; | |||
There was a problem hiding this comment.
Nice that we can use the explicit ML types! ++ 🎉
There was a problem hiding this comment.
I was a little wary of this one... I'm getting no linter complaints, and that file is just types, so I think we should be fine.
The long job names were causing the panel to overflow.
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This was referenced Mar 25, 2020
rylnd
added a commit
that referenced
this pull request
Mar 25, 2020
* Add basic help text to ML Job dropdown on Rule form * Use EUI's preferred layout for form fields * Add a link to ML in the Job select help text * Restrict timeline picker to EUI guidelines Don't display the row as fullwidth, lest the help text wrap across the entire page. It only looks okay now because it was a short sentence; adding the ML Job select with its wrapped text caused some visual weirdness, so this at least makes it consistent. * Add placeholder option to ML Job dropdown * Humanize rule type on Rule Description component This is displayed both on the readonly form view, and the Rule Details page. * Add useMlCapabilities hook This is a base hook that we can combine with our permissions helpers. * Restrict ML Rule creation to ML Admins If we're auto-activating jobs on their behalf, they'll need to be an admin. * Extract ML Job status helpers to separate file * WIP: Enrich Rule Description with ML Job Data This adds the auditMessage as well as a link to ML; actual status is next * Display job status as a badge on Rule Details Also simplifies the layout of these job details. * Port helper tests to new location * Fix DescriptionStep tests now that they use useSiemJobs UseSiemJobs uses uiSettings, so we need to use our kibana mocks here. * Fix responsiveness of ML Rule Details The long job names were causing the panel to overflow.
rylnd
commented
Mar 25, 2020
| @@ -266,3 +268,27 @@ export const buildNoteDescription = (label: string, note: string): ListItems[] = | |||
| } | |||
| return []; | |||
| }; | |||
|
|
|||
| export const buildRuleTypeDescription = (label: string, ruleType: RuleType): ListItems[] => { | |||
There was a problem hiding this comment.
@MadameSheema here's the terminal point of those Rule Details changes if you're interested. I haven't addressed the sliders discrepancy but I'll ping you on that when it's resolved!
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Delete any items that are not applicable to this PR.
For maintainers