[backport] Plugin installer support for .tgz file types #6147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be an in-place refactor without any additional behaviors or side effects.
These file extensions should be interchangeable, so there's no reason for our plugin installer not to support them. We actually did support .tgz file types up until we added .zip support.
The module is generic enough not to require an overly specific name, and it exposes more things than simply a default function, so it should be a noun.
|
jenkins, test it |
epixa
added a commit
that referenced
this pull request
Feb 8, 2016
[backport] Plugin installer support for .tgz file types
elasticsearch-bot
pushed a commit
that referenced
this pull request
Feb 8, 2016
This should be an in-place refactor without any additional behaviors or side effects. Fixes #6147
elasticsearch-bot
pushed a commit
that referenced
this pull request
Feb 8, 2016
These file extensions should be interchangeable, so there's no reason for our plugin installer not to support them. We actually did support .tgz file types up until we added .zip support. Fixes #6147
elasticsearch-bot
pushed a commit
that referenced
this pull request
Feb 8, 2016
The module is generic enough not to require an overly specific name, and it exposes more things than simply a default function, so it should be a noun. Fixes #6147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These file extensions should be interchangeable, so there's no reason
for our plugin installer not to support them. We actually did support
.tgz file types up until we added .zip support.
The first commit is a minor refactor to DRY up the code a bit.
The second commit adds .tgz support.
To test this, confirm that the plugin installer still handles .zip, and .tar.gz,
but also .tgz.
Backports PR #6083 for issue #6074