Upgrade Node.js to version 12

.ci/Dockerfile

@@ -1,7 +1,7 @@
 # NOTE: This Dockerfile is ONLY used to run certain tasks in CI. It is not used to run Kibana or as a distributable.
 # If you're looking for the Kibana Docker image distributable, please see: src/dev/build/tasks/os_packages/docker_generator/templates/dockerfile.template.ts
 
-ARG NODE_VERSION=10.22.1
+ARG NODE_VERSION=12.19.0
 
 FROM node:${NODE_VERSION} AS base
 

.node-version

@@ -1 +1 @@
-10.22.1
+12.19.0

.nvmrc

@@ -1 +1 @@
-10.22.1
+12.19.0

package.json

@@ -81,7 +81,7 @@
     "**/@types/hapi__boom": "^7.4.1",
     "**/@types/hapi__hapi": "^18.2.6",
     "**/@types/hapi__mimos": "4.1.0",
-    "**/@types/node": ">=10.17.17 <10.20.0",
+    "**/@types/node": ">=12.12.64 <12.20.0",
     "**/cross-fetch/node-fetch": "^2.6.1",
     "**/deepmerge": "^4.2.2",
     "**/fast-deep-equal": "^3.1.1",
@@ -97,7 +97,7 @@
     "**/typescript": "4.0.2"
   },
   "engines": {
-    "node": "10.22.1",
+    "node": "12.19.0",
     "yarn": "^1.21.1"
   },
   "dependencies": {
@@ -499,7 +499,7 @@
     "@types/mustache": "^0.8.31",
     "@types/ncp": "^2.0.1",
     "@types/nock": "^10.0.3",
-    "@types/node": ">=10.17.17 <10.20.0",
+    "@types/node": ">=12.12.64 <12.20.0",
     "@types/node-fetch": "^2.5.7",
     "@types/node-forge": "^0.9.5",
     "@types/nodemailer": "^6.2.1",
@@ -561,7 +561,7 @@
     "@types/vinyl-fs": "^2.4.11",
     "@types/watchpack": "^1.1.5",
     "@types/webpack": "^4.41.3",
-    "@types/webpack-env": "^1.15.2",
+    "@types/webpack-env": "^1.15.3",
     "@types/webpack-merge": "^4.1.5",
     "@types/write-pkg": "^3.1.0",
     "@types/xml-crypto": "^1.4.1",

packages/kbn-config-schema/src/types/stream_type.test.ts

@@ -57,7 +57,13 @@ test('includes namespace in failure', () => {
 describe('#defaultValue', () => {
   test('returns default when undefined', () => {
     const value = new Stream();
-    expect(schema.stream({ defaultValue: value }).validate(undefined)).toStrictEqual(value);
+    expect(schema.stream({ defaultValue: value }).validate(undefined)).toMatchInlineSnapshot(`
+      Stream {
+        "_events": Object {},
+        "_eventsCount": 0,
+        "_maxListeners": undefined,
+      }
+    `);
   });
 
   test('returns value when specified', () => {

packages/kbn-dev-utils/src/proc_runner/proc.ts

@@ -91,9 +91,9 @@ export function startProc(name: string, options: ProcOptions, log: ToolingLog) {
   });
 
   if (stdin) {
-    childProcess.stdin.end(stdin, 'utf8');
+    childProcess.stdin!.end(stdin, 'utf8'); // TypeScript note: As long as the proc stdio[1] is 'pipe', then stdin will not be null
   } else {
-    childProcess.stdin.end();
+    childProcess.stdin!.end(); // TypeScript note: As long as the proc stdio[1] is 'pipe', then stdin will not be null
   }
 
   let stopCalled = false;
@@ -123,8 +123,8 @@ export function startProc(name: string, options: ProcOptions, log: ToolingLog) {
   ).pipe(share());
 
   const lines$ = Rx.merge(
-    observeLines(childProcess.stdout),
-    observeLines(childProcess.stderr)
+    observeLines(childProcess.stdout!), // TypeScript note: As long as the proc stdio[1] is 'pipe', then stdout will not be null
+    observeLines(childProcess.stderr!) // TypeScript note: As long as the proc stdio[1] is 'pipe', then stderr will not be null
   ).pipe(
     tap((line) => log.write(` ${chalk.gray('proc')} [${chalk.gray(name)}] ${line}`)),
     share()

packages/kbn-es-archiver/src/actions/load.ts

@@ -43,7 +43,7 @@ import {
 // are not listened for
 const pipeline = (...streams: Readable[]) =>
   streams.reduce((source, dest) =>
-    source.once('error', (error) => dest.emit('error', error)).pipe(dest as any)
+    source.once('error', (error) => dest.destroy(error)).pipe(dest as any)
   );
 
 export async function loadAction({

packages/kbn-es-archiver/src/lib/streams/concat_stream_providers.test.js

@@ -44,7 +44,7 @@ describe('concatStreamProviders() helper', () => {
       () =>
         new Readable({
           read() {
-            this.emit('error', new Error('foo'));
+            this.destroy(new Error('foo'));
           },
         }),
     ]);

packages/kbn-es-archiver/src/lib/streams/concat_stream_providers.ts

@@ -50,7 +50,7 @@ export function concatStreamProviders(
 
     source
       // proxy errors from the source to the destination
-      .once('error', (error) => destination.emit('error', error))
+      .once('error', (error) => destination.destroy(error))
       // pipe the source to the destination but only proxy the
       // end event if this is the last source
       .pipe(destination, { end: isLast });

packages/kbn-optimizer/src/optimizer/get_mtimes.ts

@@ -23,7 +23,7 @@ import * as Rx from 'rxjs';
 import { mergeMap, map, catchError } from 'rxjs/operators';
 import { allValuesFrom } from '../common';
 
-const stat$ = Rx.bindNodeCallback(Fs.stat);
+const stat$ = Rx.bindNodeCallback<Fs.PathLike, Fs.Stats>(Fs.stat);
 
 /**
  * get mtimes of referenced paths concurrently, limit concurrency to 100

packages/kbn-optimizer/src/optimizer/observe_worker.ts

@@ -164,7 +164,8 @@ export function observeWorker(
         type: 'worker started',
         bundles,
       }),
-      observeStdio$(proc.stdout).pipe(
+      // TypeScript note: As long as the proc stdio[1] is 'pipe', then stdout will not be null
+      observeStdio$(proc.stdout!).pipe(
         map(
           (line): WorkerStdio => ({
             type: 'worker stdio',
@@ -173,7 +174,8 @@ export function observeWorker(
           })
         )
       ),
-      observeStdio$(proc.stderr).pipe(
+      // TypeScript note: As long as the proc stdio[2] is 'pipe', then stderr will not be null
+      observeStdio$(proc.stderr!).pipe(
         map(
           (line): WorkerStdio => ({
             type: 'worker stdio',

packages/kbn-pm/dist/index.js

@@ -32273,8 +32273,10 @@ function spawnStreaming(command, args, opts, {
     mergeMultiline: true,
     tag: color.bold(prefix)
   });
-  spawned.stdout.pipe(prefixedStdout).pipe(streamToLog(debug));
-  spawned.stderr.pipe(prefixedStderr).pipe(streamToLog(debug));
+  spawned.stdout.pipe(prefixedStdout).pipe(streamToLog(debug)); // TypeScript note: As long as the proc stdio[1] is 'pipe', then stdout will not be null
+
+  spawned.stderr.pipe(prefixedStderr).pipe(streamToLog(debug)); // TypeScript note: As long as the proc stdio[2] is 'pipe', then stderr will not be null
+
   return spawned;
 }
 
@@ -51377,7 +51379,8 @@ const WatchCommand = {
     await Object(_utils_parallelize__WEBPACK_IMPORTED_MODULE_2__["parallelizeBatches"])(batchedProjects, async pkg => {
       const completionHint = await Object(_utils_watch__WEBPACK_IMPORTED_MODULE_4__["waitUntilWatchIsReady"])(pkg.runScriptStreaming(watchScriptName, {
         debug: false
-      }).stdout);
+      }).stdout // TypeScript note: As long as the proc stdio[1] is 'pipe', then stdout will not be null
+      );
       _utils_log__WEBPACK_IMPORTED_MODULE_1__["log"].success(`[${pkg.name}] Initial build completed (${completionHint}).`);
     });
   }

packages/kbn-pm/src/commands/watch.ts

@@ -80,7 +80,7 @@ export const WatchCommand: ICommand = {
       const completionHint = await waitUntilWatchIsReady(
         pkg.runScriptStreaming(watchScriptName, {
           debug: false,
-        }).stdout
+        }).stdout! // TypeScript note: As long as the proc stdio[1] is 'pipe', then stdout will not be null
       );
 
       log.success(`[${pkg.name}] Initial build completed (${completionHint}).`);

packages/kbn-pm/src/utils/child_process.ts

@@ -71,8 +71,8 @@ export function spawnStreaming(
   const prefixedStdout = logTransformer({ tag: color.bold(prefix) });
   const prefixedStderr = logTransformer({ mergeMultiline: true, tag: color.bold(prefix) });
 
-  spawned.stdout.pipe(prefixedStdout).pipe(streamToLog(debug));
-  spawned.stderr.pipe(prefixedStderr).pipe(streamToLog(debug));
+  spawned.stdout!.pipe(prefixedStdout).pipe(streamToLog(debug)); // TypeScript note: As long as the proc stdio[1] is 'pipe', then stdout will not be null
+  spawned.stderr!.pipe(prefixedStderr).pipe(streamToLog(debug)); // TypeScript note: As long as the proc stdio[2] is 'pipe', then stderr will not be null
 
   return spawned;
 }

packages/kbn-test/src/functional_test_runner/lib/docker_servers/container_logs.ts

@@ -35,8 +35,8 @@ export function observeContainerLogs(name: string, containerId: string, log: Too
   const logLine$ = new Rx.Subject<string>();
 
   Rx.merge(
-    observeLines(logsProc.stdout).pipe(tap((line) => log.info(`[docker:${name}] ${line}`))),
-    observeLines(logsProc.stderr).pipe(tap((line) => log.error(`[docker:${name}] ${line}`)))
+    observeLines(logsProc.stdout!).pipe(tap((line) => log.info(`[docker:${name}] ${line}`))), // TypeScript note: As long as the proc stdio[1] is 'pipe', then stdout will not be null
+    observeLines(logsProc.stderr!).pipe(tap((line) => log.error(`[docker:${name}] ${line}`))) // TypeScript note: As long as the proc stdio[2] is 'pipe', then stderr will not be null
   ).subscribe(logLine$);
 
   return logLine$.asObservable();

packages/kbn-test/src/functional_test_runner/lib/lifecycle_phase.test.ts

@@ -59,11 +59,17 @@ describe('with randomness', () => {
     );
 
     await phase.trigger();
+
+    // `phase.trigger()` uses `Math.random` to sort the internal array of
+    // handlers. But since the sorting algorithm used internally in
+    // `Array.prototype.sort` is not spec'ed, it can change between Node.js
+    // versions, and as a result the expected output below might not match if
+    // you up/downgrade Node.js.
     expect(order).toMatchInlineSnapshot(`
       Array [
-        "one",
         "three",
         "two",
+        "one",
       ]
     `);
   });

packages/kbn-test/src/kbn/kbn_test_config.ts

@@ -39,9 +39,9 @@ export const kbnTestConfig = new (class KbnTestConfig {
       const testKibanaUrl = url.parse(process.env.TEST_KIBANA_URL);
       return {
         protocol: testKibanaUrl.protocol?.slice(0, -1),
-        hostname: testKibanaUrl.hostname,
+        hostname: testKibanaUrl.hostname === null ? undefined : testKibanaUrl.hostname,
         port: testKibanaUrl.port ? parseInt(testKibanaUrl.port, 10) : undefined,
-        auth: testKibanaUrl.auth,
+        auth: testKibanaUrl.auth === null ? undefined : testKibanaUrl.auth,
         username: testKibanaUrl.auth?.split(':')[0],
         password: testKibanaUrl.auth?.split(':')[1],
       };

src/cli/serve/integration_tests/reload_logging_config.test.ts

@@ -121,14 +121,15 @@ describe('Server logging configuration', function () {
           '--verbose',
         ]);
 
-        const message$ = Rx.fromEvent(child.stdout, 'data').pipe(
+        // TypeScript note: As long as the child stdio[1] is 'pipe', then stdout will not be null
+        const message$ = Rx.fromEvent(child.stdout!, 'data').pipe(
           map((messages) => String(messages).split('\n').filter(Boolean))
         );
 
         await message$
           .pipe(
             // We know the sighup handler will be registered before this message logged
-            filter((messages) => messages.some((m) => m.includes('setting up root'))),
+            filter((messages: string[]) => messages.some((m) => m.includes('setting up root'))),
             take(1)
           )
           .toPromise();
@@ -189,14 +190,15 @@ describe('Server logging configuration', function () {
 
         child = Child.spawn(process.execPath, [kibanaPath, '--oss', '--config', configFilePath]);
 
-        const message$ = Rx.fromEvent(child.stdout, 'data').pipe(
+        // TypeScript note: As long as the child stdio[1] is 'pipe', then stdout will not be null
+        const message$ = Rx.fromEvent(child.stdout!, 'data').pipe(
           map((messages) => String(messages).split('\n').filter(Boolean))
         );
 
         await message$
           .pipe(
             // We know the sighup handler will be registered before this message logged
-            filter((messages) => messages.some((m) => m.includes('setting up root'))),
+            filter((messages: string[]) => messages.some((m) => m.includes('setting up root'))),
             take(1)
           )
           .toPromise();

src/core/public/http/types.ts

@@ -206,12 +206,19 @@ export interface HttpRequestInit {
 
 /** @public */
 export interface HttpFetchQuery {
-  [key: string]:
-    | string
-    | number
-    | boolean
-    | undefined
-    | Array<string | number | boolean | undefined>;
+  /**
+   * TypeScript note: Technically we should use this interface instead, but @types/node uses the below stricter
+   * definition, so to avoid TypeScript errors, we'll restrict our version.
+   *
+   * [key: string]:
+   *   | string
+   *   | number
+   *   | boolean
+   *   | Array<string | number | boolean>
+   *   | undefined
+   *   | null;
+   */
+  [key: string]: string | number | boolean | string[] | number[] | boolean[] | undefined | null;
 }
 
 /**

src/core/public/public.api.md

@@ -624,8 +624,7 @@ export interface HttpFetchOptionsWithPath extends HttpFetchOptions {
 
 // @public (undocumented)
 export interface HttpFetchQuery {
-    // (undocumented)
-    [key: string]: string | number | boolean | undefined | Array<string | number | boolean | undefined>;
+    [key: string]: string | number | boolean | string[] | number[] | boolean[] | undefined | null;
 }
 
 // @public

src/core/public/utils/crypto/sha256.ts

@@ -118,6 +118,18 @@ const K = [
 
 const W = new Array(64);
 
+type BufferEncoding =
+  | 'ascii'
+  | 'utf8'
+  | 'utf-8'
+  | 'utf16le'
+  | 'ucs2'
+  | 'ucs-2'
+  | 'base64'
+  | 'latin1'
+  | 'binary'
+  | 'hex';
+
 /* eslint-disable  no-bitwise, no-shadow */
 export class Sha256 {
   private _a: number;
@@ -157,7 +169,7 @@ export class Sha256 {
     this._s = 0;
   }
 
-  update(data: string | Buffer, encoding?: string): Sha256 {
+  update(data: string | Buffer, encoding?: BufferEncoding): Sha256 {
     if (typeof data === 'string') {
       encoding = encoding || 'utf8';
       data = Buffer.from(data, encoding);