Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jenkins] refer to sizes in most pipeline code #62082

Merged
merged 3 commits into from
Apr 4, 2020
Merged

[jenkins] refer to sizes in most pipeline code #62082

merged 3 commits into from
Apr 4, 2020

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Mar 31, 2020

In order to make it easier to attempt running workers on a specific operating system, this updates the pipeline code to use size params, rather than label params, and then at the last moment translates sizes to labels with workers.label(size).

@spalger spalger marked this pull request as ready for review March 31, 2020 22:39
@spalger spalger added release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v6.8.9 v7.0.3 v7.6.3 v7.7.0 v7.8.0 v8.0.0 labels Mar 31, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@spalger spalger requested a review from brianseeders March 31, 2020 23:33
@spalger
Copy link
Contributor Author

spalger commented Apr 3, 2020

@elasticmachine merge upstream

brianseeders
brianseeders approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@brianseeders brianseeders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit 4962fe9 into elastic:master Apr 4, 2020
@spalger spalger mentioned this pull request Apr 4, 2020
Merged
spalger added a commit to spalger/kibana that referenced this pull request Apr 4, 2020
@spalger @elasticmachine
[jenkins] refer to sizes in most pipeline code (elastic#62082)
c1c45e7 
* [jenkins] refer to sizes in most pipeline code

* switch back to `linux && immutable` for small instances

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
spalger added a commit to spalger/kibana that referenced this pull request Apr 4, 2020
@spalger @elasticmachine
[jenkins] refer to sizes in most pipeline code (elastic#62082)
8d99d8d 
* [jenkins] refer to sizes in most pipeline code

* switch back to `linux && immutable` for small instances

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This was referenced Apr 4, 2020
Merged
Merged
spalger added a commit to spalger/kibana that referenced this pull request Apr 4, 2020
@spalger @elasticmachine
[jenkins] refer to sizes in most pipeline code (elastic#62082)
627cffc 
* [jenkins] refer to sizes in most pipeline code

* switch back to `linux && immutable` for small instances

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
spalger added a commit that referenced this pull request Apr 4, 2020
@spalger @elasticmachine
[7.x] [jenkins] refer to sizes in most pipeline code (#62082) (#62549)
fec6b7c 
* [jenkins] refer to sizes in most pipeline code

* switch back to `linux && immutable` for small instances

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
spalger added a commit that referenced this pull request Apr 4, 2020
@spalger @elasticmachine
[7.7] [jenkins] refer to sizes in most pipeline code (#62082) (#62550)
3aea932 
* [jenkins] refer to sizes in most pipeline code

* switch back to `linux && immutable` for small instances

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
spalger added a commit that referenced this pull request Apr 4, 2020
@spalger @elasticmachine
[7.6] [jenkins] refer to sizes in most pipeline code (#62082) (#62551)
4ecda06 
* [jenkins] refer to sizes in most pipeline code

* switch back to `linux && immutable` for small instances

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@spalger spalger deleted the implement/aliases-labels branch April 4, 2020 17:24
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 6, 2020
@gmmorris
Merge branch 'event-log/query-support' of github.com:gmmorris/kibana …
503bea6 
…into event-log/query-support

* 'event-log/query-support' of github.com:gmmorris/kibana: (41 commits)
  [jenkins] refer to sizes in most pipeline code (elastic#62082)
  skip flaky suite (elastic#60470)
  [Discover] Fix flaky FT in field visualize (elastic#62418)
  [ML] Data Frame Analytics: Fix feature importance (elastic#61761)
  [Reporting] Use a shim for server config (elastic#62086)
  [Reporting] Fix reporting for non-default spaces (elastic#62226)
  Fix bug that coerced empty scaled float value to 0 (elastic#62251)
  [SIEM] [Detection Engine] Remove has manage api keys requireme… (elastic#62446)
  [Maps] Safely handle empty string and invalid strings from EuiColorPicker (elastic#62507)
  Reporting/bug more blacklisted headers (elastic#62389)
  [SIEM] Prevent undefined behavior in our ML popover (elastic#62498)
  [SIEM] [Detection Engine] remove all unknowns from all rules t… (elastic#62327)
  base changes for active/current node styling (elastic#62007)
  [kbn/ui-shared-deps] expand and split (elastic#62364)
  [ML] DF Analytics - ensure destination index pattern created (elastic#62450)
  Mark rule run as failure if there was an error (elastic#62383)
  Add docs for metric explorer alerts (elastic#62314)
  skip flaky suite (elastic#62281)
  [SIEM][Detection Engine] Fixes export of single rule and the icons
  fixes flakiness (elastic#62406)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianseeders brianseeders brianseeders approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.6.3 v7.7.0 v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spalger @elasticmachine @kibanamachine @brianseeders