Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Refresh index and also show more info to user regarding index/data #62606

Merged
merged 23 commits into from
Apr 18, 2020
Merged

[Uptime] Refresh index and also show more info to user regarding index/data #62606

merged 23 commits into from
Apr 18, 2020

Conversation

shahzad31
Copy link
Contributor

Summary

Fixes: #61874

Updated Index/Data Missing States.

No Index found

image

No Uptime Data

image

@shahzad31 shahzad31 added release_note:fix v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.8.0 labels Apr 6, 2020
@shahzad31 shahzad31 requested a review from andrewvc April 6, 2020 13:06
@shahzad31 shahzad31 self-assigned this Apr 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

andrewvc
andrewvc reviewed Apr 7, 2020
View reviewed changes
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. I'd love @katrin-freihofner 's thoughts on this as well before I give it the green light.

x-pack/legacy/plugins/uptime/public/state/api/dynamic_settings.ts Show resolved Hide resolved
katrin-freihofner
katrin-freihofner reviewed Apr 7, 2020
View reviewed changes
Copy link
Contributor

@katrin-freihofner katrin-freihofner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's great. The only things I'm wondering about are:

  • The wording for the settings link was unclear to me.
  • I'm not sure why we need the link to the Uptime tutorial twice? Once in the link Configure Heartbeat... and once in the CTA button.

x-pack/legacy/plugins/uptime/public/components/functional/empty_state/data_or_index_missing.tsx Outdated Show resolved Hide resolved
x-pack/legacy/plugins/uptime/public/components/functional/empty_state/data_or_index_missing.tsx Outdated Show resolved Hide resolved
x-pack/legacy/plugins/uptime/public/components/functional/empty_state/data_or_index_missing.tsx Outdated Show resolved Hide resolved
@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@shahzad31
Copy link
Contributor Author

@andrewvc can you re-review this.

justinkambic
justinkambic reviewed Apr 10, 2020
View reviewed changes
x-pack/legacy/plugins/uptime/public/components/functional/empty_state/data_or_index_missing.tsx
body={
<>
<p>
<FormattedMessage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do we think about these FormattedMessage components? We've talked about exporting calls to i18n.translate, but these don't seem to clutter up the component nearly as much in terms of readability IMO. That said, I'd be fine with creating named FC exports from the same translation files.

CC @andrewvc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes i think we can keep formatted messages inline to jsx.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with these as-is, but don't have a strong opinion

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@andrewvc
Copy link
Contributor

@elasticmachine merge upstream

andrewvc
andrewvc requested changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@andrewvc andrewvc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Love the change here, but could use some tweaks: My thoughts on copy.

"No indices found matching pattern heartbeat-8*"

then a second line in smaller text below reading:

"If you have not yet setup heartbeat, add data with Heartbeat(link). If you have setup heartbeat and confirmed data is being sent to Elasticsearch, check your index pattern settings(link) and insure they are aligned with your Heartbeat config"

@drewpost your thoughts?

Also, I don't know if we need the button. I link that it's a clear call to action, but it's odd in that it doesn't fit in well with the copy. Thoughts?

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

andrewvc
andrewvc approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks great.

@justinkambic any remaining concerns before merge?

@shahzad31 shahzad31 merged commit c59320c into elastic:master Apr 18, 2020
@shahzad31 shahzad31 deleted the refresh-uptime-app-after-data-added branch April 18, 2020 11:41
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 20, 2020
@jloleysens
Merge branch 'feature/ingest-node-pipelines' of github.com:elastic/ki…
0c9eee7 
…bana into ingest-node-pipelines/privileges

* 'feature/ingest-node-pipelines' of github.com:elastic/kibana: (126 commits)
  [SEARCH] Cleanup fetch soon (elastic#63320)
  skip flaky suite (elastic#58692)
  [Uptime] Refresh index and also show more info to user regardi… (elastic#62606)
  [Drilldowns] Fix back button by removing panels from url in dashboard in view mode (elastic#62415)
  [platform] serve plugins from /bundles/plugin:${id}
  [Alerting] Documentation for how to pre-configure connectors. (elastic#63807)
  skip flaky suite (elastic#63621)
  Revert "skip flaky suite (elastic#63747)"
  skip flaky suite (elastic#63747)
  [SIEM][Detections Engine] - Update rule.lists to be rule.exceptions_list (elastic#63717)
  [SIEM] Flaky test fix: Bump find_statuses timeout (elastic#63900)
  [Uptime] Add cert API request and runtime type checking (elastic#63062)
  [Lens] Allow table to scroll horizontally (elastic#63805)
  [Metrics UI] Allow users to create alerts from the central Alerts UI (elastic#63803)
  Migrate legacy maps licensing (x-pack/tilemap) to NP (elastic#63539)
  [Alerting] "Create alert" and alert list design improvements (elastic#63515)
  [Lens] Fix existence for dotted paths in _source (elastic#63752)
  Example plugins in X-Pack (elastic#63823)
  [ML] Migrate Mocha unit tests to Jest: migrate job utils and query utils tests (elastic#63775)
  Endpoint: middleware receive immutable versions of state and actions (elastic#63802)
  ...
shahzad31 added a commit to shahzad31/kibana that referenced this pull request Apr 20, 2020
@shahzad31 @elasticmachine
[Uptime] Refresh index and also show more info to user regardi… (elas…
d7ab111 
…tic#62606)

* Refresh index and also show more info to user

* updated type

* updated type

* updated test

* updated formatting

* update text

* updated types

* updated translation

* update

* fixed types

* updated code

* fixed types

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@shahzad31 shahzad31 mentioned this pull request Apr 20, 2020
Merged
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 20, 2020
@jloleysens
Merge branch 'feature/ingest-node-pipelines' of github.com:elastic/ki…
597b148 
…bana into pipeline-editor-part-mvp-2

* 'feature/ingest-node-pipelines' of github.com:elastic/kibana: (127 commits)
  [Ingest pipelines] Polish details panel and empty list (elastic#63926)
  [SEARCH] Cleanup fetch soon (elastic#63320)
  skip flaky suite (elastic#58692)
  [Uptime] Refresh index and also show more info to user regardi… (elastic#62606)
  [Drilldowns] Fix back button by removing panels from url in dashboard in view mode (elastic#62415)
  [platform] serve plugins from /bundles/plugin:${id}
  [Alerting] Documentation for how to pre-configure connectors. (elastic#63807)
  skip flaky suite (elastic#63621)
  Revert "skip flaky suite (elastic#63747)"
  skip flaky suite (elastic#63747)
  [SIEM][Detections Engine] - Update rule.lists to be rule.exceptions_list (elastic#63717)
  [SIEM] Flaky test fix: Bump find_statuses timeout (elastic#63900)
  [Uptime] Add cert API request and runtime type checking (elastic#63062)
  [Lens] Allow table to scroll horizontally (elastic#63805)
  [Metrics UI] Allow users to create alerts from the central Alerts UI (elastic#63803)
  Migrate legacy maps licensing (x-pack/tilemap) to NP (elastic#63539)
  [Alerting] "Create alert" and alert list design improvements (elastic#63515)
  [Lens] Fix existence for dotted paths in _source (elastic#63752)
  Example plugins in X-Pack (elastic#63823)
  [ML] Migrate Mocha unit tests to Jest: migrate job utils and query utils tests (elastic#63775)
  ...
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 21, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

shahzad31 added a commit that referenced this pull request Apr 23, 2020
@shahzad31 @elasticmachine
[7.x] [Uptime] Refresh index and also show more info to user r… (#63946)
3e815cc 
* [Uptime] Certificate expiration threshold settings (#63682)

* update settings

* added cert form

* update settings

* update types

* update test

* updated tests

* updated snapshots

* [Uptime] Refresh index and also show more info to user regardi… (#62606)

* Refresh index and also show more info to user

* updated type

* updated type

* updated test

* updated formatting

* update text

* updated types

* updated translation

* update

* fixed types

* updated code

* fixed types

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* updated snapshots

* up snapshots

* update trans

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katrin-freihofner katrin-freihofner katrin-freihofner left review comments

@justinkambic justinkambic justinkambic left review comments

@andrewvc andrewvc andrewvc approved these changes

Assignees

@shahzad31 shahzad31

Labels
release_note:fix Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Uptime] Refresh does not work when index not found
6 participants
@shahzad31 @elasticmachine @andrewvc @kibanamachine @justinkambic @katrin-freihofner