Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/timeouts 4.x #6377

Closed
wants to merge 12 commits into from
Closed

Fix/timeouts 4.x #6377

wants to merge 12 commits into from

Conversation

w33ble
Copy link
Contributor

@w33ble w33ble commented Mar 2, 2016

Closes #6331
Supersedes #6341

  • Fix Hapi proxy/node socket timeout
  • Fix Hapi request timeout
  • Fix Elasticsearch ping timout

@epixa
Copy link
Contributor

epixa commented Mar 2, 2016

Should these changes not be going into master?

@w33ble
Copy link
Contributor Author

w33ble commented Mar 2, 2016

@epixa these specific changes, not the way they are. All the renaming in master has brought with it a world of mere conflicts, so I'm going to apply these changes again by hand and open a new PR against master.

@epixa
Copy link
Contributor

epixa commented Mar 2, 2016

Is that something you could get sorted today? I don't like the idea of us having improvements in older branches without those changes in master. We really do need to be able to make the assumption that if something exists in one version, it definitely exists in future versions.

@w33ble
Copy link
Contributor Author

w33ble commented Mar 2, 2016

Yup. In fact, I can open the PR against master before I merge this one if it makes you feel better too.

@epixa
Copy link
Contributor

epixa commented Mar 2, 2016

It sure would!

w33ble added a commit to w33ble/kibana that referenced this pull request Mar 2, 2016
@w33ble w33ble mentioned this pull request Mar 2, 2016
@w33ble
Copy link
Contributor Author

w33ble commented Mar 2, 2016

@epixa Your wish is my command: #6385

elasticsearch-bot pushed a commit that referenced this pull request Mar 2, 2016
@elasticsearch-bot
Copy link

Joe Fleming merged this into the following branches!

Branch Commits
4.x 7a41ce6, bfec231, c7faec0, 9992c37, 9bdca03, 8ae2a84, 25364f3, 6e04331, daae976, cfdcd4d, 367d355
4.5 b968cc9, 5776eec, 0bfeeea, f3830d9, 0dc2b33, 7f4b548, c91a17e, 4f2e328, 53805de, 60a0167, 139d8ac

elasticsearch-bot pushed a commit that referenced this pull request Mar 2, 2016
elasticsearch-bot pushed a commit that referenced this pull request Mar 2, 2016
elasticsearch-bot pushed a commit that referenced this pull request Mar 2, 2016
elasticsearch-bot pushed a commit that referenced this pull request Mar 2, 2016
elasticsearch-bot pushed a commit that referenced this pull request Mar 2, 2016
elasticsearch-bot pushed a commit that referenced this pull request Mar 2, 2016
should be needed, we're setting the timeout on the ES proxy route, and this mixes concerns

Fixes #6377
elasticsearch-bot pushed a commit that referenced this pull request Mar 2, 2016
make the value match the es client default and the joi config value

Fixes #6377
elasticsearch-bot pushed a commit that referenced this pull request Mar 2, 2016
elasticsearch-bot pushed a commit that referenced this pull request Mar 2, 2016
elasticsearch-bot pushed a commit that referenced this pull request Mar 2, 2016
elasticsearch-bot pushed a commit that referenced this pull request Mar 2, 2016
elasticsearch-bot pushed a commit that referenced this pull request Mar 2, 2016
elasticsearch-bot pushed a commit that referenced this pull request Mar 2, 2016
should be needed, we're setting the timeout on the ES proxy route, and this mixes concerns

Fixes #6377
elasticsearch-bot pushed a commit that referenced this pull request Mar 2, 2016
make the value match the es client default and the joi config value

Fixes #6377
@w33ble w33ble mentioned this pull request Mar 2, 2016
@w33ble
Copy link
Contributor Author

w33ble commented Mar 2, 2016

I don't know why Jarvis didn't close this PR automatically...

@w33ble w33ble closed this Mar 2, 2016
@tbragin tbragin mentioned this pull request Mar 16, 2016
3 tasks
1Copenut added a commit that referenced this pull request Dec 2, 2022
`eui@70.2.4` ⏩ `eui@70.4.0`

- "Fixed EuiButtonGroup firing onChange twice" required changing some
tests from `click` to `change`
___

## [`70.4.0`](https://github.com/elastic/eui/tree/v70.4.0)

- Updated `EuiTourStep.footerAction` type to accept `ReactNode[]`
([#6384](elastic/eui#6384))
- Vertically aligned all footer content so that `euiTourStepIndicator`
is always centered ([#6384](elastic/eui#6384))
- Added `filterInCircle` glyph to `EuiIcon`
([#6385](elastic/eui#6385))
- Added `color` prop to `EuiBeacon`
([#6420](elastic/eui#6420))
- Added the `euiMaxBreakpoint` and `euiMinBreakpoint` CSS-in-JS
utilities for creating min/max-width media queries
([#6431](elastic/eui#6431))

**Bug fixes**

- Restores the previous match operator behaviour when the query value is
split into multiple terms after analysis.
([#6409](elastic/eui#6409))
- Fixed missing slide-in animation on `EuiCollapsibleNav`s and left-side
`EuiFlyout`s ([#6422](elastic/eui#6422))
- Fix bug in `EuiCard` where footer were not aligned to the bottom of
the card ([#6424](elastic/eui#6424))
- Fixed multiple component media queries for consumers with custom theme
breakpoints ([#6431](elastic/eui#6431))

## [`70.3.0`](https://github.com/elastic/eui/tree/v70.3.0)

- `EuiSearchBar` now automatically wraps special characters not used by
query syntax in quotes
([#6356](elastic/eui#6356))
- Added `alignment` prop to `EuiBetaBadge`
([#6361](elastic/eui#6361))
- `EuiButton` now accepts `minWidth={false}`
([#6373](elastic/eui#6373))

**Bug fixes**

- Fixed `EuiPageTemplate` not correctly passing the `component` prop to
the inner main content wrapper.
([#6352](elastic/eui#6352))
- `EuiSkipLink` now correctly calls `onClick` even when
`fallbackDestination` is invalid
([#6355](elastic/eui#6355))
- Permanently fixed `EuiModal` to not cause scroll-jumping issues on
modal open ([#6360](elastic/eui#6360))
- Re-fixed `EuiPageSection` not correctly merging `contentProps.css`
([#6365](elastic/eui#6365))
- Fixed `EuiTab` not defaulting to size `m`
([#6366](elastic/eui#6366))
- Fixed the shadow sizes of `.eui-yScrollWithShadows` and
`.eui-xScrollWithShadows`
([#6374](elastic/eui#6374))
- Fixed bug in `EuiCard` where the inner content in vertical cards was
not growing 100% in width
([#6377](elastic/eui#6377))
- Fixed incorrect margins in `EuiSuperDatePicker` caused by `EuiFlex`
CSS gap change ([#6380](elastic/eui#6380))
- Fixed visual bug in nested `EuiFlexGroup`s, where the parent
`EuiFlexGroup` is responsive but a child `EuiFlexGroup` is not
([#6381](elastic/eui#6381))

**CSS-in-JS conversions**

- Converted `EuiModal` to Emotion
([#6321](elastic/eui#6321))

**Fixes**

- `EuiButton` no longer outputs unnecessary inline styles for
`minWidth={0}` or `minWidth={false}`
([#6373](elastic/eui#6373))
- `EuiFacetButton` no longer reports type issues when passing props
accepted by `EuiButton`
([#6373](elastic/eui#6373))

Co-authored-by: Constance Chen <constance.chen@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants