Backport #6027 to 4.5 - Pass Transport object as the context when callWithRequest is asked to use a transport method #6483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when called normally instead of assuming client is the context for everything
|
Pending tests passing, LGTM |
|
Er, wait a sec. @spalger the description says this is supposed to backport to 4.5, but the pull actually targets 4.x which is 4.6. Does this need to be backported to 4.5, 4.6, or both? |
|
Ah, good catch. |
|
Spencer Alger merged this into the following branches!
|
elasticsearch-bot
pushed a commit
that referenced
this pull request
Mar 9, 2016
… when called normally instead of assuming client is the context for everything Fixes #6483
|
Can we try to get into the habit of adding the |
|
👍 |
epixa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6027 fixes the way that
callWithRequesthandles alternate context's (like transport) and is needed in 4.5.