[SIEM] Fix auto save for template timeline #65001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angorayc
added
release_note:skip
|
Pinging @elastic/siem (Team:SIEM) |
angorayc
changed the title
|
@elasticmachine merge upstream |
angorayc
commented
May 4, 2020
| @@ -236,6 +237,9 @@ export const createTimelineEpic = <State>(): Epic< | |||
| ...savedTimeline, | |||
| savedObjectId: response.timeline.savedObjectId, | |||
| version: response.timeline.version, | |||
| timelineType: response.timeline.timelineType ?? TimelineType.default, | |||
| templateTimelineId: response.timeline.templateTimelineId ?? null, | |||
| templateTimelineVersion: response.timeline.templateTimelineVersion ?? null, | |||
| isSaving: false, | |||
There was a problem hiding this comment.
I put these back as after updating/creating the timeline, we need to assign the value back to the store from api's response. Otherwise we might encounter with error like timeline's version conflict
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
patrykkopycinski
approved these changes
May 5, 2020
angorayc
added a commit
to angorayc/kibana
that referenced
this pull request
May 5, 2020
* update save timeline * fix types * allow template timeline to be updated via import * fix unit tests * fix for review * handle update timeline Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
angorayc
added a commit
that referenced
this pull request
May 5, 2020
* update save timeline * fix types * allow template timeline to be updated via import * fix unit tests * fix for review * handle update timeline Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I found a bug in my create template timeline PR, it is after updating a template timeline, it becomes a normal timeline as I didn't add relevant attributes into open timeline's modal
so we didn't sent the right info when persisting timeline.
also after I adding these, I still get a templateTimelineVersion conflict, therefore I'd like to update my persistTimeline api to allow sending the same templateTimelineVersion, and I'll bump the version from api's side.
Checklist
Delete any items that are not applicable to this PR.
For maintainers