Update ingest API for ES 5.0 mapping changes #6553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are pretty minimal changes, as long as they pass tests, which they do, this LGTM |
Bargs
pushed a commit
that referenced
this pull request
Mar 18, 2016
Update ingest API for ES 5.0 mapping changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're eventually going to need to make these changes everywhere to support breaking changes in 5.0 (#6411) but the full fix is on hold till we can handle reindexing. In the meantime, testing Add Data has become impossible with fresh builds of ES, so this PR updates just the ingest API to account for those breaking changes. It should be safe to make these changes now since they don't touch the .kibana index or users' existing indices.
What's updated?
index: 'not_analyed'toindex: truestringmappings in the default ingest template totext/keyword