[internal] Replace empty var declarations with let #6653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any time there is a variable defined in a JS file without also storing a value in it, we know that definition cannot be converted to a const, so we convert it to a let. For example: `var blah;` becomes `let blah;` Some of these things variables might be unused, and many others can likely be switched to const with only minor refactoring, but the commit is very large, so there are no changes in it other than the 1:1 switch.
|
LGTM |
This was referenced Mar 25, 2016
elastic-jasper
added a commit
that referenced
this pull request
Mar 25, 2016
--------- **Commit 1:** [internal] Replace empty var declaration with let Any time there is a variable defined in a JS file without also storing a value in it, we know that definition cannot be converted to a const, so we convert it to a let. For example: `var blah;` becomes `let blah;` Some of these things variables might be unused, and many others can likely be switched to const with only minor refactoring, but the commit is very large, so there are no changes in it other than the 1:1 switch. * Original sha: bfc59e9 * Authored by Court Ewing <court@epixa.com> on 2016-03-24T22:27:29Z
elastic-jasper
added a commit
that referenced
this pull request
Mar 25, 2016
--------- **Commit 1:** [internal] Replace empty var declaration with let Any time there is a variable defined in a JS file without also storing a value in it, we know that definition cannot be converted to a const, so we convert it to a let. For example: `var blah;` becomes `let blah;` Some of these things variables might be unused, and many others can likely be switched to const with only minor refactoring, but the commit is very large, so there are no changes in it other than the 1:1 switch. * Original sha: bfc59e9 * Authored by Court Ewing <court@epixa.com> on 2016-03-24T22:27:29Z
epixa
added a commit
that referenced
this pull request
Mar 28, 2016
--------- **Commit 1:** [internal] Replace empty var declaration with let Any time there is a variable defined in a JS file without also storing a value in it, we know that definition cannot be converted to a const, so we convert it to a let. For example: `var blah;` becomes `let blah;` Some of these things variables might be unused, and many others can likely be switched to const with only minor refactoring, but the commit is very large, so there are no changes in it other than the 1:1 switch. * Original sha: bfc59e9 * Authored by Court Ewing <court@epixa.com> on 2016-03-24T22:27:29Z
epixa
added a commit
that referenced
this pull request
Mar 28, 2016
--------- **Commit 1:** [internal] Replace empty var declaration with let Any time there is a variable defined in a JS file without also storing a value in it, we know that definition cannot be converted to a const, so we convert it to a let. For example: `var blah;` becomes `let blah;` Some of these things variables might be unused, and many others can likely be switched to const with only minor refactoring, but the commit is very large, so there are no changes in it other than the 1:1 switch. * Original sha: bfc59e9 * Authored by Court Ewing <court@epixa.com> on 2016-03-24T22:27:29Z
epixa
added a commit
that referenced
this pull request
Mar 28, 2016
--------- **Commit 1:** [internal] Replace empty var declaration with let Any time there is a variable defined in a JS file without also storing a value in it, we know that definition cannot be converted to a const, so we convert it to a let. For example: `var blah;` becomes `let blah;` Some of these things variables might be unused, and many others can likely be switched to const with only minor refactoring, but the commit is very large, so there are no changes in it other than the 1:1 switch. * Original sha: bfc59e9 * Authored by Court Ewing <court@epixa.com> on 2016-03-24T22:27:29Z
epixa
pushed a commit
that referenced
this pull request
Mar 28, 2016
--------- **Commit 1:** [internal] Replace empty var declaration with let Any time there is a variable defined in a JS file without also storing a value in it, we know that definition cannot be converted to a const, so we convert it to a let. For example: `var blah;` becomes `let blah;` Some of these things variables might be unused, and many others can likely be switched to const with only minor refactoring, but the commit is very large, so there are no changes in it other than the 1:1 switch. * Original sha: bfc59e9 * Authored by Court Ewing <court@epixa.com> on 2016-03-24T22:27:29Z
elastic-jasper
added a commit
that referenced
this pull request
Mar 29, 2016
--------- **Commit 1:** [internal] Replace empty var declaration with let Any time there is a variable defined in a JS file without also storing a value in it, we know that definition cannot be converted to a const, so we convert it to a let. For example: `var blah;` becomes `let blah;` Some of these things variables might be unused, and many others can likely be switched to const with only minor refactoring, but the commit is very large, so there are no changes in it other than the 1:1 switch. * Original sha: bfc59e9 * Authored by Court Ewing <court@epixa.com> on 2016-03-24T22:27:29Z
epixa
added a commit
that referenced
this pull request
Mar 29, 2016
--------- **Commit 1:** [internal] Replace empty var declaration with let Any time there is a variable defined in a JS file without also storing a value in it, we know that definition cannot be converted to a const, so we convert it to a let. For example: `var blah;` becomes `let blah;` Some of these things variables might be unused, and many others can likely be switched to const with only minor refactoring, but the commit is very large, so there are no changes in it other than the 1:1 switch. * Original sha: bfc59e9 * Authored by Court Ewing <court@epixa.com> on 2016-03-24T22:27:29Z
elastic-jasper
added a commit
that referenced
this pull request
Mar 29, 2016
--------- **Commit 1:** [internal] Replace empty var declaration with let Any time there is a variable defined in a JS file without also storing a value in it, we know that definition cannot be converted to a const, so we convert it to a let. For example: `var blah;` becomes `let blah;` Some of these things variables might be unused, and many others can likely be switched to const with only minor refactoring, but the commit is very large, so there are no changes in it other than the 1:1 switch. * Original sha: bfc59e9 * Authored by Court Ewing <court@epixa.com> on 2016-03-24T22:27:29Z
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any time there is a variable defined in a JS file without also storing a
value in it, we know that definition cannot be converted to a const, so
we convert it to a let.
For example:
var blah;becomeslet blah;Some of these things variables might be unused, and many others can
likely be switched to const with only minor refactoring, but the commit
is very large, so there are no changes in it other than the 1:1 switch.