[internal] Replace var assignments with let in non-ui #6706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change was applied to all directories under src/ except for the ui/ directory. Only .js files were searched. This was an automatic replacement from var to let for any variable declaration that doubles as the initial assignment. Ultimately we want most of these to be converted to const, but this commit is so large that it warrants breaking each step of automation up into its own commit. For example: `var foo = 'bar';` becomes `let foo = 'var';` This was accomplished by replacing: find: `var ([a-zA-Z_$][0-9a-zA-Z_$]*)(\s+)=` replace: `let $1$2=`
|
I killed that test because there were more important ones waiting in the queue. I'll re-run tests on this later. |
|
jenkins, test it |
This file is not transpiled, so in order to use es6 features such as const/let, we need to enable strict mode.
|
Blegh, so there are actually two commits in this pull request. The first is an automated change, as the PR describes, and it includes essentially everything in this PR. The second commit is a single change to a single file that is needed because that file is not transpiled with babel. It might be easier to review them separately. The bulk of this change and what the PR title/description is actually describing: 9eee35d Normally I'd just squash them, but the main commit is large and was created completely automatically. I figured the separate commits make it easier to review. |
|
LGTM 🎉 |
|
LGTM |
epixa
added a commit
that referenced
this pull request
Apr 1, 2016
--------- **Commit 1:** [internal] Replace var assignments with let in non-ui This change was applied to all directories under src/ except for the ui/ directory. Only .js files were searched. This was an automatic replacement from var to let for any variable declaration that doubles as the initial assignment. Ultimately we want most of these to be converted to const, but this commit is so large that it warrants breaking each step of automation up into its own commit. For example: `var foo = 'bar';` becomes `let foo = 'var';` This was accomplished by replacing: find: `var ([a-zA-Z_$][0-9a-zA-Z_$]*)(\s+)=` replace: `let $1$2=` * Original sha: 9eee35d * Authored by Court Ewing <court@epixa.com> on 2016-03-30T17:53:10Z **Commit 2:** [internal] use strict in babel_options This file is not transpiled, so in order to use es6 features such as const/let, we need to enable strict mode. * Original sha: f3ec776 * Authored by Court Ewing <court@epixa.com> on 2016-03-30T21:43:10Z
epixa
added a commit
that referenced
this pull request
Apr 1, 2016
--------- **Commit 1:** [internal] Replace var assignments with let in non-ui This change was applied to all directories under src/ except for the ui/ directory. Only .js files were searched. This was an automatic replacement from var to let for any variable declaration that doubles as the initial assignment. Ultimately we want most of these to be converted to const, but this commit is so large that it warrants breaking each step of automation up into its own commit. For example: `var foo = 'bar';` becomes `let foo = 'var';` This was accomplished by replacing: find: `var ([a-zA-Z_$][0-9a-zA-Z_$]*)(\s+)=` replace: `let $1$2=` * Original sha: 9eee35d * Authored by Court Ewing <court@epixa.com> on 2016-03-30T17:53:10Z **Commit 2:** [internal] use strict in babel_options This file is not transpiled, so in order to use es6 features such as const/let, we need to enable strict mode. * Original sha: f3ec776 * Authored by Court Ewing <court@epixa.com> on 2016-03-30T21:43:10Z
elastic-jasper
added a commit
that referenced
this pull request
Apr 1, 2016
--------- **Commit 1:** [internal] Replace var assignments with let in non-ui This change was applied to all directories under src/ except for the ui/ directory. Only .js files were searched. This was an automatic replacement from var to let for any variable declaration that doubles as the initial assignment. Ultimately we want most of these to be converted to const, but this commit is so large that it warrants breaking each step of automation up into its own commit. For example: `var foo = 'bar';` becomes `let foo = 'var';` This was accomplished by replacing: find: `var ([a-zA-Z_$][0-9a-zA-Z_$]*)(\s+)=` replace: `let $1$2=` * Original sha: 9eee35d * Authored by Court Ewing <court@epixa.com> on 2016-03-30T17:53:10Z **Commit 2:** [internal] use strict in babel_options This file is not transpiled, so in order to use es6 features such as const/let, we need to enable strict mode. * Original sha: f3ec776 * Authored by Court Ewing <court@epixa.com> on 2016-03-30T21:43:10Z
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was applied to all directories under src/ except for the ui/
directory. Only .js files were searched.
This was an automatic replacement from var to let for any variable
declaration that doubles as the initial assignment. Ultimately we want
most of these to be converted to const, but this commit is so large that
it warrants breaking each step of automation up into its own commit.
For example:
var foo = 'bar';becomeslet foo = 'var';This was accomplished by replacing:
find:
var ([a-zA-Z_$][0-9a-zA-Z_$]*)(\s+)=replace:
let $1$2=