-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metrics UI] Add back context variables with descriptions #67487
Conversation
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
@elasticmachine merge upstream |
@phillipb From the user's perspective it's not clear that each of these context variables is followed by
Can we clarify it somehow? Maybe by default add condition0 to each context variable as soon as the user clicks on the dropdown? Thoughts? |
@sorantis yeah, I added this issue to address that #67396. It's now added to 7.9 as a documentation fix. Because the number of conditions is dynamic and the context variable list is static, not sure how we could create a better UX. We could hardcode some values in the context for example Unfortunately, we don't control the context variable dropdown, so we can't change what's inserted in the message when a user clicks a variable. |
…ore-context-variables
…na into add-more-context-variables
By all means we should update our docs. I'm wondering if there's any way we could put this information on the UI too. It feels like the docs will be helpful only after the user has already struggled with making it work :) |
@sorantis we could link to think docs from the flyout maybe? We could also file an issue with kibana-alerting to see if they have thoughts or plans around this. |
@elasticmachine merge upstream |
...k/plugins/infra/server/lib/alerting/metric_threshold/register_metric_threshold_alert_type.ts
Outdated
Show resolved
Hide resolved
…na into add-more-context-variables
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go
Friendly reminder: Looks like this PR hasn’t been backported yet. |
5 similar comments
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
…69216) * Add context variables for metric, value and threshold with descriptions * Remove timestamp from this PR * sentences are hard * Fix lint rules * Add more usage examples Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Summary
Add back the old context variables with clearer names and descriptions. Fixes: #65974.
Checklist
Delete any items that are not applicable to this PR.