Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] PR #6792 to 4.2 #6807

Merged
merged 1 commit into from
Apr 15, 2016
Merged

[backport] PR #6792 to 4.2 #6807

merged 1 commit into from
Apr 15, 2016

Conversation

elastic-jasper
Copy link
Contributor

Backport PR #6792

Commit 1:
Update selenium from 2.48.2 to 2.53.0 to work with latest Firefox 45.0.1

Commit 2:
Update downloadSelenium to match version in intern.js.

Commit 3:
Add selenium-server-standalone jar md5.


Backported based on diff from PR #6802

---------

**Commit 1:**
Update selenium from 2.48.2 to 2.53.0 to work with latest Firefox 45.0.1

* Original sha: 81821fc
* Authored by LeeDr <lee.drengenberg@elastic.co> on 2016-04-05T20:46:06Z

**Commit 2:**
Update downloadSelenium to match version in intern.js.

* Original sha: 431fe52
* Authored by LeeDr <lee.drengenberg@elastic.co> on 2016-04-06T12:36:06Z

**Commit 3:**
Add selenium-server-standalone jar md5.

* Original sha: 4002140
* Authored by LeeDr <lee.drengenberg@elastic.co> on 2016-04-06T13:46:17Z
@LeeDr
Copy link

LeeDr commented Apr 6, 2016

The test on Jenkins failed before it got to the point of this change, downloading Selenium. So I think this PR is blocked.

@epixa
Copy link
Contributor

epixa commented Apr 14, 2016

I think the builds are broken on 4.2 for entirely different reasons. We'll probably never need to touch 4.2 again, which is why we aren't bothering fixing the builds.

Given that this change has gone green everywhere else, I'd recommend just pushing it directly to 4.2 and closing this PR.

@rashidkpc
Copy link
Contributor

@LeeDr @epixa what do you want to do with this? We're not likely cutting another 4.2 release as court noted, so don't invest any time in making this work

@LeeDr
Copy link

LeeDr commented Apr 15, 2016

@epixa suggested I go ahead and merge it, and I agree, but the merge button is grayed-out. I can use command line from my end but I have a couple of other changes in progress and didn't want to switch off of those right now. OK if I merge this later?

@epixa
Copy link
Contributor

epixa commented Apr 15, 2016

I got you covered - I manually pushed this to 4.2.

@epixa epixa closed this Apr 15, 2016
@epixa epixa deleted the jasper/backport/6792/6802/4.2 branch April 15, 2016 14:25
@LeeDr
Copy link

LeeDr commented Apr 15, 2016

Thanks !

@epixa epixa restored the jasper/backport/6792/6802/4.2 branch April 15, 2016 14:27
@epixa epixa reopened this Apr 15, 2016
@epixa epixa merged commit 738b2c1 into 4.2 Apr 15, 2016
@epixa epixa deleted the jasper/backport/6792/6802/4.2 branch April 15, 2016 14:28
@epixa
Copy link
Contributor

epixa commented Apr 15, 2016

Whoops, correction... I thought I manually pushed it. We're good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants