Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the Writing documentation section in CONTRIBUTING.md #68434

Merged
merged 2 commits into from
Jun 9, 2020

Conversation

KOTungseth
Copy link
Contributor

Summary

Received some feedback that node scripts/docs.js --open was confusing to some outside of the Kibana team, so I added ./docs/build_docs --doc kibana/docs/index.asciidoc --chunk 1 --open. I also did the writerly thing and made a few edits.

@KOTungseth KOTungseth self-assigned this Jun 5, 2020
@KOTungseth KOTungseth added release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v7.9.0 v8.0.0 labels Jun 5, 2020
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KOTungseth KOTungseth merged commit 835964b into elastic:master Jun 9, 2020
@KOTungseth KOTungseth deleted the docs/build-edit branch June 9, 2020 15:43
KOTungseth added a commit to KOTungseth/kibana that referenced this pull request Jun 9, 2020
…#68434)

* Updated the Writing documentation section in CONTRIBUTING.md

* More changes
KOTungseth added a commit to KOTungseth/kibana that referenced this pull request Jun 9, 2020
…#68434)

* Updated the Writing documentation section in CONTRIBUTING.md

* More changes
KOTungseth added a commit that referenced this pull request Jun 9, 2020
…#68665)

* Updated the Writing documentation section in CONTRIBUTING.md

* More changes
KOTungseth added a commit that referenced this pull request Jun 9, 2020
…#68664)

* Updated the Writing documentation section in CONTRIBUTING.md

* More changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants