-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Data - CSV Upload UI #6845
Merged
Merged
Add Data - CSV Upload UI #6845
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
57c391a
[Wizard] Creates a new CSV Add Data Wizard
Bargs ed5e4e3
Remove pipeline creation step from CSV wizard
Bargs d6bac79
Merge branch 'feature/ingest' into ingest/uploadUI
Bargs e23f54a
[Wizard] Improved index pattern input validation
Bargs a32364f
[Wizard] Default index pattern input value on pattern review step is now
Bargs e11b270
Refresh index pattern cache after saving or deleting via ingest service
Bargs 271e78f
Enhance kbnUrl to allow setting app state on target url
Bargs c080b3d
[Wizard] Done button now sends you to the correct index pattern on di…
Bargs 4140db8
[Wizard] code cleanup
Bargs f604b12
[Wizard] Ensure row values are ordered correctly
Bargs 625ca75
[Wizard] Fix test errors caused by async task, refreshing kibana inde…
Bargs 8205f4b
Remove default index name and add a placeholder
Bargs 526d5d4
Update help text so it doesn't imply that you can add data to existin…
Bargs 2228e86
Limit the number of errors initially displayed on upload data step wi…
Bargs 873ff3f
Update id parsing logic since the API changed the ID format
Bargs a2f1e17
Increment papaparse error row by 1 so the reported row number matches…
Bargs 001ff8b
Fail early if CSV contains empty column headers
Bargs 900a4ee
Extract complex error formatting logic into its own function
Bargs 3143c06
Added API test so we don't forget that the ID format is a part of the…
Bargs f237ec0
Don't allow duplicate headers in CSVs
Bargs d04aea5
[FileUpload] Correctly detect the existence of directive attributes
Bargs 66880a3
Improve parsing performance
Bargs b925554
Truncate columns to 20 because we don't really need more, and perform…
Bargs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth pulling this logic into a function? Especially since the format of the data has changed now during the development of this feature?