Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Data - CSV Upload UI #6845

Merged
merged 23 commits into from
Jun 1, 2016
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
57c391a
[Wizard] Creates a new CSV Add Data Wizard
Bargs Mar 17, 2016
ed5e4e3
Remove pipeline creation step from CSV wizard
Bargs May 10, 2016
d6bac79
Merge branch 'feature/ingest' into ingest/uploadUI
Bargs May 17, 2016
e23f54a
[Wizard] Improved index pattern input validation
Bargs May 17, 2016
a32364f
[Wizard] Default index pattern input value on pattern review step is now
Bargs May 19, 2016
e11b270
Refresh index pattern cache after saving or deleting via ingest service
Bargs May 19, 2016
271e78f
Enhance kbnUrl to allow setting app state on target url
Bargs May 19, 2016
c080b3d
[Wizard] Done button now sends you to the correct index pattern on di…
Bargs May 19, 2016
4140db8
[Wizard] code cleanup
Bargs May 20, 2016
f604b12
[Wizard] Ensure row values are ordered correctly
Bargs May 20, 2016
625ca75
[Wizard] Fix test errors caused by async task, refreshing kibana inde…
Bargs May 20, 2016
8205f4b
Remove default index name and add a placeholder
Bargs May 25, 2016
526d5d4
Update help text so it doesn't imply that you can add data to existin…
Bargs May 25, 2016
2228e86
Limit the number of errors initially displayed on upload data step wi…
Bargs May 25, 2016
873ff3f
Update id parsing logic since the API changed the ID format
Bargs May 25, 2016
a2f1e17
Increment papaparse error row by 1 so the reported row number matches…
Bargs May 25, 2016
001ff8b
Fail early if CSV contains empty column headers
Bargs May 25, 2016
900a4ee
Extract complex error formatting logic into its own function
Bargs May 25, 2016
3143c06
Added API test so we don't forget that the ID format is a part of the…
Bargs May 25, 2016
f237ec0
Don't allow duplicate headers in CSVs
Bargs May 26, 2016
d04aea5
[FileUpload] Correctly detect the existence of directive attributes
Bargs May 31, 2016
66880a3
Improve parsing performance
Bargs May 31, 2016
b925554
Truncate columns to 20 because we don't really need more, and perform…
Bargs Jun 1, 2016
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ modules.get('apps/settings')
_.forEach(res.data, (response) => {
this.created += response.created;
this.formattedErrors = this.formattedErrors.concat(_.map(_.get(response, 'errors.index'), (doc) => {
return `${doc._id.split('-', 1)[0].replace('L', 'Line ').trim()}: ${doc.error.type} - ${doc.error.reason}`;
return `Line ${doc._id.substr(doc._id.lastIndexOf(':') + 1)}: ${doc.error.type} - ${doc.error.reason}`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth pulling this logic into a function? Especially since the format of the data has changed now during the development of this feature?

}));
if (!_.isEmpty(_.get(response, 'errors.other'))) {
this.formattedErrors = this.formattedErrors.concat(response.errors.other);
Expand Down