Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VEGA is missing scroll bars #68766

Merged
merged 2 commits into from
Jun 11, 2020
Merged

VEGA is missing scroll bars #68766

merged 2 commits into from
Jun 11, 2020

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Jun 10, 2020

Closes: #22240

Summary

Describe the bug: I started using VEGA to create visualizations in KIBANA.
When trying to visualize a NxM matrix, which exceeds the size of the screen, there was no vertical or horizontal scroll bars.

Steps to reproduce:

  1. In KIBANA create a new VEGA visualization
  2. create any visualization that exceeds screen size
  3. example:
    {
    "$schema":"https://vega.github.io/schema/vega/v3.json",
    "autosize":"none",
    "width":1600,
    "height":1600
    }

Before:
image

After:
image

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@alexwizp alexwizp requested review from cchaos and stratoula June 10, 2020 13:34
@alexwizp alexwizp self-assigned this Jun 10, 2020
@alexwizp alexwizp added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Vega Vega visualizations v7.9.0 v8.0.0 release_note:fix labels Jun 10, 2020
@alexwizp alexwizp marked this pull request as ready for review June 10, 2020 15:30
@alexwizp alexwizp requested a review from a team as a code owner June 10, 2020 15:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@cchaos
Copy link
Contributor

cchaos commented Jun 10, 2020

@alexwizp Can you add some before and after screenshots?

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested it on OSx Chrome, Safari and FF. It displays the bars only when the size is extended and I think is pretty helpful for the user.

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 It also works properly when embedded in a Dashboard

@alexwizp alexwizp merged commit d91c954 into elastic:master Jun 11, 2020
alexwizp added a commit to alexwizp/kibana that referenced this pull request Jun 11, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
alexwizp added a commit that referenced this pull request Jun 12, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Vega Vega visualizations release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VEGA is missing scroll bars
5 participants