[internal] Replace var with let in ui/public A-D #6907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins, test it |
|
LGTM |
This change was applied to any .js files under directories beginning with `a` through `d` in src/ui/public. This was an automatic replacement from var to let for any variable declaration that doubles as the initial assignment. Ultimately we want most of these to be converted to const, but this commit is so large that it warrants breaking each step of automation up into its own commit. For example: `var foo = 'bar';` becomes `let foo = 'var';` This was accomplished by replacing: find: `var ([a-zA-Z_$][0-9a-zA-Z_$]*)(\s+)=` replace: `let $1$2=`
| @@ -1,5 +1,5 @@ | |||
| import uiModules from 'ui/modules'; | |||
| var module = uiModules.get('kibana'); | |||
| let module = uiModules.get('kibana'); | |||
There was a problem hiding this comment.
Is this just github being silly that these aren't highlighted?
|
It would appear it is github being silly. LGTM! |
epixa
added a commit
that referenced
this pull request
Apr 14, 2016
--------- **Commit 1:** [internal] Replace var with let in ui/public A-D This change was applied to any .js files under directories beginning with `a` through `d` in src/ui/public. This was an automatic replacement from var to let for any variable declaration that doubles as the initial assignment. Ultimately we want most of these to be converted to const, but this commit is so large that it warrants breaking each step of automation up into its own commit. For example: `var foo = 'bar';` becomes `let foo = 'var';` This was accomplished by replacing: find: `var ([a-zA-Z_$][0-9a-zA-Z_$]*)(\s+)=` replace: `let $1$2=` * Original sha: 4c535f6 * Authored by Court Ewing <court@epixa.com> on 2016-04-12T22:18:38Z
elastic-jasper
added a commit
that referenced
this pull request
Apr 14, 2016
--------- **Commit 1:** [internal] Replace var with let in ui/public A-D This change was applied to any .js files under directories beginning with `a` through `d` in src/ui/public. This was an automatic replacement from var to let for any variable declaration that doubles as the initial assignment. Ultimately we want most of these to be converted to const, but this commit is so large that it warrants breaking each step of automation up into its own commit. For example: `var foo = 'bar';` becomes `let foo = 'var';` This was accomplished by replacing: find: `var ([a-zA-Z_$][0-9a-zA-Z_$]*)(\s+)=` replace: `let $1$2=` * Original sha: 4c535f6 * Authored by Court Ewing <court@epixa.com> on 2016-04-12T22:18:38Z
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was applied to any .js files under directories beginning
with
athroughdin src/ui/public.This was an automatic replacement from var to let for any variable
declaration that doubles as the initial assignment. Ultimately we want
most of these to be converted to const, but this commit is so large that
it warrants breaking each step of automation up into its own commit.
For example:
var foo = 'bar';becomeslet foo = 'var';This was accomplished by replacing:
find:
var ([a-zA-Z_$][0-9a-zA-Z_$]*)(\s+)=replace:
let $1$2=