Migrate timelion to the NP. #69160

VladLasitsa · 2020-06-15T15:02:05Z

closes #67468

Summary

Migrated timelion to the new platform.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

VladLasitsa · 2020-06-16T08:55:44Z

@elasticmachine merge upstream

VladLasitsa · 2020-06-17T10:25:25Z

@elasticmachine merge upstream

VladLasitsa · 2020-06-23T11:47:12Z

src/optimize/base_optimizer.js

@@ -270,7 +270,6 @@ export default class BaseOptimizer {
              name: 'commons',
              chunks: (chunk) =>
                chunk.canBeInitial() && chunk.name !== 'light_theme' && chunk.name !== 'dark_theme',
-              minChunks: 2,


After migration "timeloin" commons.styles.css is no longer loaded. Because of this bootstrap.js went to 'exception' path and I got an error related to redirect from old URL to new, also font_awesome styles didn't load. I deleted minСhunks property so that commons.styles can be loaded.

@spalger Could you please take a look? We need your eyes here:)

Looks like this is outdated now (sorry, was on vacation last week)

elasticmachine · 2020-06-23T11:48:09Z

Pinging @elastic/kibana-app (Team:KibanaApp)

flash1293 · 2020-06-23T11:53:31Z

#68284 touches the same thing - once it's merged it should fix this problem as well.

cchaos

SASS files were simply moved. 👍

flash1293

Noticed a few things:

You have to resolve a few conflicts because of another PR I merged in. Make sure to carry over this line: https://github.com/elastic/kibana/blob/master/src/legacy/core_plugins/timelion/public/plugin.ts#L70 It makes sure font-awesome is loaded correctly (you have to depend on kibanaLegacy to do so).
It's also broken in 7.8, but the "Refresh" button doesn't do anything. Could you have a look while you are at it?
When I'm using the "Save current expression as Kibana dashboard panel" function, it will create a visualization saved object, but opening it in Visualize will break the editor and render nothing (see error below). This works in 7.8

react_devtools_backend.js:6 TypeError: Cannot read property 'getOwnField' of undefined
    at visStateToEditorState (editor.js:121)
    at VisualizeAppController (editor.js:130)
    at Object.invoke (angular.js:5143)
    at $controllerInit (angular.js:11707)
    at nodeLinkFn (angular.js:10520)
    at compositeLinkFn (angular.js:9835)
    at publicLinkFn (angular.js:9700)
    at Object.link (angular-route.js:1260)
    at angular.js:1390
    at invokeLinkFn (angular.js:11269) "<div ng-view="" class="visAppWrapper ng-scope">"

Somehow panels can't be reordered by dragging anymore (works in 7.8)
Deleting panels doesn't work anymore - it will delete a panel but not the right one and afterwards the expressions in the editor don't match the selected panel

VladLasitsa · 2020-07-08T13:27:12Z

@elasticmachine merge upstream

flash1293

It seems like timelion is not torn down correctly when navigating away - When switching from Home -> Timelion -> Discover -> Timelion it won't render and all subsequent navigations to other apps won't work as well.

The rest works fine, great work there! Saving a single panel also seems to work perfectly now.

alexwizp

LGTM! Tested locally

alexwizp · 2020-07-13T08:27:26Z

@elasticmachine merge upstream

flash1293 · 2020-07-13T11:17:56Z

@alexwizp Seems like there is a requiredBundles missing:

ERROR in ./public/directives/saved_object_finder.js
10:33:54         │          Module not found: Error: import [../../../saved_objects/public] references a public export of the [savedObjects] bundle, but that bundle is not in the "requiredPlugins" or "requiredBundles" list in the plugin manifest [/dev/shm/workspace/kibana/src/plugins/timelion/kibana.json]
1

flash1293 · 2020-07-13T12:44:44Z

@alexwizp I'm not sure what caused this (I'm 85% certain it worked in an earlier iteration of this PR), but when editing the. expression, it's not possible to select an entry from the suggestion box via "arrow down" key anymore and "cmd+enter" doesn't execute the expression. Both things work in 7.8

alexwizp · 2020-07-14T07:56:37Z

@elasticmachine merge upstream

flash1293

I noticed two other things that don't work, but they are easy to fix:

When in the app, clicking the navlink doesn't take you back to a new sheet, instead nothing happens. This is the case because the URL change is not picked up by the hash history object. Visualize fixes this with the following trick: https://github.com/flash1293/kibana/blob/7c352c0702d35f3e68451936dfc7c679dd67e8e1/src/plugins/visualize/public/plugin.ts#L135 We can use the same approach in timelion
The sub-url tracker doesn't work - when switching from Timelion to Discover and back, the local state is lost. This is the case because a hash history object instead of the platform scoped history object is used. Again we can use the same fix as in visualize: https://github.com/flash1293/kibana/blob/7c352c0702d35f3e68451936dfc7c679dd67e8e1/src/plugins/visualize/public/plugin.ts#L106

Other than those, this looks good to me.

flash1293

Tested in Firefox and LGTM once green. Thanks @VladLasitsa for powering through this!

kibanamachine · 2020-07-14T15:16:21Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: ed3703e

Build metrics

@kbn/optimizer bundle module count

id	value	diff	baseline
timelion	59	+59	-

History

💚 Build #61265 succeeded c5fc79f
💚 Build #60823 succeeded 1fd161a
💔 Build #60743 failed 79424c2
💔 Build #60618 failed 220b2cb
💔 Build #60611 failed 3ea1bc7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Migrate timelion to the NP. * fixed ci * Fixed paths * fixed UI settings * Fixed ci * fix CI * Fixed some comments * Fixed browser tests * fixed state * Fixed comments * Fixed save expression * Fixed navigation * fix CI * Fixed some problem Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>

kibanamachine · 2020-07-16T15:48:44Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

Migrate timelion to the NP.

b8aaf9c

VladLasitsa requested a review from alexwizp June 15, 2020 15:02

VladLasitsa self-assigned this Jun 15, 2020

elasticmachine and others added 2 commits June 16, 2020 02:55

Merge branch 'master' into elastic#67468

be8ec89

fixed ci

0762ac2

elasticmachine and others added 7 commits June 17, 2020 04:25

Merge branch 'master' into elastic#67468

118cd23

Fixed paths

3ddf246

fixed UI settings

2c07e0e

Merge remote-tracking branch 'upstream/master' into elastic#67468

7e0e880

Fixed ci

80746ab

Merge branch 'master' into elastic#67468

95b258e

fix CI

2eb9702

VladLasitsa marked this pull request as ready for review June 23, 2020 09:21

VladLasitsa requested a review from a team June 23, 2020 09:21

VladLasitsa requested review from a team as code owners June 23, 2020 09:21

VladLasitsa added Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0 labels Jun 23, 2020

VladLasitsa commented Jun 23, 2020

View reviewed changes

VladLasitsa added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Jun 23, 2020

cchaos approved these changes Jun 23, 2020

View reviewed changes

flash1293 reviewed Jun 25, 2020

View reviewed changes

Merge remote-tracking branch 'upstream/master' into elastic#67468

2a20ad1

elasticmachine and others added 2 commits July 7, 2020 02:47

Merge branch 'master' into elastic#67468

c796c9e

Fixed save expression

1932a68

Merge branch 'master' into elastic#67468

3c52d47

flash1293 reviewed Jul 8, 2020

View reviewed changes

VladLasitsa added 2 commits July 10, 2020 15:22

Fixed navigation

3ea1bc7

Merge remote-tracking branch 'upstream/master' into elastic#67468

220b2cb

alexwizp approved these changes Jul 13, 2020

View reviewed changes

Merge branch 'master' into elastic#67468

79424c2

fix CI

1fd161a

Merge branch 'master' into elastic#67468

c5fc79f

flash1293 reviewed Jul 14, 2020

View reviewed changes

Fixed some problem

ed3703e

flash1293 approved these changes Jul 14, 2020

View reviewed changes

VladLasitsa merged commit d8823d8 into elastic:master Jul 14, 2020

VladLasitsa mentioned this pull request Jul 14, 2020

[7.x] Migrate timelion to the NP. (#69160) #71676

Merged

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 16, 2020

timroes added v7.10.0 and removed v7.9.0 labels Jul 16, 2020

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 17, 2020

flash1293 pushed a commit that referenced this pull request Jul 17, 2020

Migrate timelion to the NP. (#69160) (#71676)

9b0c006

VladLasitsa mentioned this pull request Jul 22, 2020

Timelion app "save as visualization" doesn't work #70429

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate timelion to the NP. #69160

Migrate timelion to the NP. #69160

VladLasitsa commented Jun 15, 2020

VladLasitsa commented Jun 16, 2020

VladLasitsa commented Jun 17, 2020

VladLasitsa Jun 23, 2020 •

edited

Loading

spalger Jun 29, 2020

elasticmachine commented Jun 23, 2020

flash1293 commented Jun 23, 2020 •

edited

Loading

cchaos left a comment

flash1293 left a comment

VladLasitsa commented Jul 8, 2020

flash1293 left a comment

alexwizp left a comment

alexwizp commented Jul 13, 2020

flash1293 commented Jul 13, 2020

flash1293 commented Jul 13, 2020

alexwizp commented Jul 14, 2020

flash1293 left a comment

flash1293 left a comment

kibanamachine commented Jul 14, 2020

kibanamachine commented Jul 16, 2020

Migrate timelion to the NP. #69160

Migrate timelion to the NP. #69160

Conversation

VladLasitsa commented Jun 15, 2020

Summary

Checklist

For maintainers

VladLasitsa commented Jun 16, 2020

VladLasitsa commented Jun 17, 2020

VladLasitsa Jun 23, 2020 • edited Loading

Choose a reason for hiding this comment

spalger Jun 29, 2020

Choose a reason for hiding this comment

elasticmachine commented Jun 23, 2020

flash1293 commented Jun 23, 2020 • edited Loading

cchaos left a comment

Choose a reason for hiding this comment

flash1293 left a comment

Choose a reason for hiding this comment

VladLasitsa commented Jul 8, 2020

flash1293 left a comment

Choose a reason for hiding this comment

alexwizp left a comment

Choose a reason for hiding this comment

alexwizp commented Jul 13, 2020

flash1293 commented Jul 13, 2020

flash1293 commented Jul 13, 2020

alexwizp commented Jul 14, 2020

flash1293 left a comment

Choose a reason for hiding this comment

flash1293 left a comment

Choose a reason for hiding this comment

kibanamachine commented Jul 14, 2020

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

History

kibanamachine commented Jul 16, 2020

VladLasitsa Jun 23, 2020 •

edited

Loading

flash1293 commented Jun 23, 2020 •

edited

Loading