Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] [kbn/optimizer] share all plugin bundles (#68986) #69234

Merged
merged 8 commits into from
Jun 17, 2020
Merged

[7.x] [kbn/optimizer] share all plugin bundles (#68986) #69234

merged 8 commits into from
Jun 17, 2020

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Jun 16, 2020 •
edited
Loading

Backports the following commits to 7.x:

@spalger spalger marked this pull request as draft June 16, 2020 07:35
Spencer and others added 2 commits June 16, 2020 00:43
@spalger @elasticmachine
[kbn/optimizer] share all plugin bundles (elastic#68986)
dd442ca 
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@spalger
[BundleRefPlugin] resolve imports to files too
1495503 
(cherry picked from commit 2bb6ac1a796c6b8661d9ca6c33bef9e23d7a0764)
@spalger spalger force-pushed the backport/7.x/pr-68986 branch from cb14975 to 1495503 Compare June 16, 2020 07:43
@spalger
Copy link
Contributor Author

spalger commented Jun 16, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
advancedSettings 10 -164 174
apmOss 4 +1 3
bfetch 13 +1 12
charts 154 +1 153
console 31 -152 183
core 309 +2 307
dashboard 109 -225 334
data 209 -84 293
devTools 11 +1 10
discover 75 -231 306
embeddable 33 -62 95
esUiShared 98 +66 32
expressions 96 -176 272
indexPatternManagement 34 -158 192
inputControlVis 10 +1 9
inspector 33 -17 50
kibanaLegacy 5 +1 4
kibanaReact 233 +1 232
kibanaUtils 159 -3 162
management 15 -153 168
mapsLegacy 115 -147 262
navigation 13 +1 12
newsfeed 3 +1 2
regionMap 153 -110 263
savedObjects 17 +1 16
savedObjectsManagement 13 -165 178
share 23 +1 22
statusPage 2 +1 1
telemetry 11 +1 10
telemetryManagementSection 4 -171 175
tileMap 155 -109 264
uiActions 18 +1 17
usageCollection 3 +1 2
visTypeMarkdown 157 -1 158
visTypeMetric 157 -23 180
visTypeTable 162 -22 184
visTypeTagcloud 159 -1 160
visTypeTimelion 167 +1 166
visTypeTimeseries 385 -302 687
visTypeVega 179 -111 290
visTypeVislib 230 -6 236
visTypeXy 2 +1 1
visualizations 22 -299 321
visualize 175 -243 418
alerts 22 +2 20
apm 655 -967 1622
beats_management 183 -164 347
canvas 664 -931 1595
cloud 4 +1 3
crossClusterReplication 62 -323 385
dashboardEnhanced 4 -133 137
dashboardMode 3 -331 334
dataEnhanced 4 -141 145
drilldowns 3 -133 136
embeddableEnhanced 3 -133 136
features 6 +1 5
fileUpload 12 +1 11
globalSearch 16 +1 15
graph 94 -160 254
grokdebugger 9 -155 164
indexLifecycleManagement 94 -291 385
indexManagement 146 -228 374
infra 605 -1017 1622
ingestManager 356 +1 355
ingestPipelines 240 -229 469
lens 82 -445 527
licenseManagement 92 -178 270
licensing 8 +1 7
logstash 148 -34 182
maps 457 -242 699
mapsLegacyLicensing 2 +1 1
ml 351 -330 681
monitoring 124 -171 295
observability 20 +1 19
painlessLab 12 -152 164
remoteClusters 68 -162 230
reporting 19 -300 319
rollup 133 -199 332
searchprofiler 26 -151 177
security 219 -232 451
securitySolution 780 -886 1666
snapshotRestore 25 -163 188
spaces 72 -168 240
transform 154 -594 748
triggers_actions_ui 101 -175 276
uiActionsEnhanced 23 -112 135
upgradeAssistant 20 -162 182
uptime 257 -1166 1423
watcher 43 -167 210
total - -14565 -

page load asset size

beta
id value diff baseline
/bundles/core/core.entry.js 1006.8KB +2.2KB 1004.6KB
/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.@elastic.js 4.0MB +1.0B 4.0MB
/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 4.5MB +20.2KB 4.5MB
/bundles/plugin/advancedSettings/advancedSettings.plugin.js 941.3KB -35.7KB 977.0KB
/bundles/plugin/alerts/alerts.plugin.js 89.5KB +2.2KB 87.3KB
/bundles/plugin/apm/apm.plugin.js 215.5KB -14.2KB 229.7KB
/bundles/plugin/apmOss/apmOss.plugin.js 4.2KB +468.0B 3.7KB
/bundles/plugin/beats_management/beats_management.plugin.js 523.0KB -35.9KB 558.9KB
/bundles/plugin/bfetch/bfetch.plugin.js 28.7KB +619.0B 28.1KB
/bundles/plugin/canvas/canvas.plugin.js 2.0MB -1.5MB 3.4MB
/bundles/plugin/charts/charts.plugin.js 833.9KB +1.1KB 832.8KB
/bundles/plugin/cloud/cloud.plugin.js 5.7KB +465.0B 5.3KB
/bundles/plugin/console/console.plugin.js 28.0KB -16.3KB 44.4KB
/bundles/plugin/crossClusterReplication/crossClusterReplication.plugin.js 152.3KB -35.4KB 187.8KB
/bundles/plugin/dashboard/dashboard.plugin.js 633.0KB -541.2KB 1.1MB
/bundles/plugin/dashboardEnhanced/dashboardEnhanced.plugin.js 143.5KB -611.6KB 755.1KB
/bundles/plugin/dashboardMode/dashboardMode.plugin.js 109.3KB -1.0MB 1.1MB
/bundles/plugin/data/data.plugin.js 1.3MB -332.6KB 1.7MB
/bundles/plugin/dataEnhanced/dataEnhanced.plugin.js 138.1KB -364.8KB 503.0KB
/bundles/plugin/devTools/devTools.plugin.js 123.9KB +641.0B 123.3KB
/bundles/plugin/discover/discover.plugin.js 220.4KB -542.2KB 762.6KB
/bundles/plugin/drilldowns/drilldowns.plugin.js 42.0KB -685.5KB 727.4KB
/bundles/plugin/embeddable/embeddable.plugin.js 304.5KB -310.6KB 615.1KB
/bundles/plugin/embeddableEnhanced/embeddableEnhanced.plugin.js 26.1KB -689.1KB 715.2KB
/bundles/plugin/esUiShared/esUiShared.plugin.js 900.6KB +129.2KB 771.4KB
/bundles/plugin/expressions/expressions.plugin.js 314.8KB -420.0KB 734.8KB
/bundles/plugin/features/features.plugin.js 13.4KB +544.0B 12.8KB
/bundles/plugin/fileUpload/fileUpload.plugin.js 688.0KB +481.0B 687.5KB
/bundles/plugin/globalSearch/globalSearch.plugin.js 29.0KB +487.0B 28.5KB
/bundles/plugin/graph/graph.plugin.js 15.3KB -175.4KB 190.7KB
/bundles/plugin/grokdebugger/grokdebugger.plugin.js 11.2KB -16.6KB 27.8KB
/bundles/plugin/home/home.plugin.js 24.8KB +621.0B 24.2KB
/bundles/plugin/indexLifecycleManagement/indexLifecycleManagement.plugin.js 184.2KB -35.7KB 219.8KB
/bundles/plugin/indexManagement/indexManagement.plugin.js 683.9KB -164.9KB 848.8KB
/bundles/plugin/indexPatternManagement/indexPatternManagement.plugin.js 137.3KB -36.1KB 173.4KB
/bundles/plugin/infra/infra.plugin.js 92.2KB -15.4KB 107.6KB
/bundles/plugin/ingestPipelines/ingestPipelines.plugin.js 30.2KB -269.8KB 300.0KB
/bundles/plugin/inputControlVis/inputControlVis.plugin.js 258.9KB +1.0KB 257.9KB
/bundles/plugin/inspector/inspector.plugin.js 238.3KB -67.4KB 305.7KB
/bundles/plugin/kibanaLegacy/kibanaLegacy.plugin.js 165.6KB +738.0B 164.9KB
/bundles/plugin/kibanaReact/kibanaReact.plugin.js 575.3KB +204.0B 575.1KB
/bundles/plugin/kibanaUtils/kibanaUtils.plugin.js 432.6KB -37.2KB 469.8KB
/bundles/plugin/lens/lens.plugin.js 746.8KB -1.2MB 1.9MB
/bundles/plugin/licenseManagement/licenseManagement.plugin.js 26.2KB -35.1KB 61.3KB
/bundles/plugin/licensing/licensing.plugin.js 21.6KB +206.0B 21.4KB
/bundles/plugin/logstash/logstash.plugin.js 141.8KB -35.7KB 177.4KB
/bundles/plugin/management/management.plugin.js 25.9KB -16.4KB 42.3KB
/bundles/plugin/maps/maps.plugin.js 220.0KB -15.2KB 235.1KB
/bundles/plugin/mapsLegacy/mapsLegacy.plugin.js 1.0MB -725.0KB 1.7MB
/bundles/plugin/mapsLegacyLicensing/mapsLegacyLicensing.plugin.js 3.9KB +507.0B 3.4KB
/bundles/plugin/ml/ml.plugin.js 1.2MB -870.7KB 2.0MB
/bundles/plugin/monitoring/monitoring.plugin.js 22.7KB -15.1KB 37.8KB
/bundles/plugin/navigation/navigation.plugin.js 122.2KB +481.0B 121.7KB
/bundles/plugin/newsfeed/newsfeed.plugin.js 22.7KB +475.0B 22.2KB
/bundles/plugin/observability/observability.plugin.js 103.3KB +365.0B 102.9KB
/bundles/plugin/painlessLab/painlessLab.plugin.js 158.8KB -16.6KB 175.5KB
/bundles/plugin/regionMap/regionMap.plugin.js 791.4KB -1023.4KB 1.8MB
/bundles/plugin/remoteClusters/remoteClusters.plugin.js 35.2KB -36.1KB 71.3KB
/bundles/plugin/reporting/reporting.plugin.js 258.3KB -656.6KB 914.9KB
/bundles/plugin/rollup/rollup.plugin.js 186.0KB -207.1KB 393.1KB
/bundles/plugin/savedObjects/savedObjects.plugin.js 196.2KB +1007.0B 195.2KB
/bundles/plugin/savedObjectsManagement/savedObjectsManagement.plugin.js 176.3KB +118.7KB 57.6KB
/bundles/plugin/searchprofiler/searchprofiler.plugin.js 42.8KB -16.7KB 59.5KB
/bundles/plugin/security/security.plugin.js 248.0KB -34.4KB 282.4KB
/bundles/plugin/share/share.plugin.js 80.5KB +626.0B 79.8KB
/bundles/plugin/snapshotRestore/snapshotRestore.plugin.js 57.5KB -35.6KB 93.2KB
/bundles/plugin/spaces/spaces.plugin.js 367.6KB -101.0KB 468.6KB
/bundles/plugin/statusPage/statusPage.plugin.js 3.6KB +480.0B 3.2KB
/bundles/plugin/telemetry/telemetry.plugin.js 77.0KB +890.0B 76.2KB
/bundles/plugin/telemetryManagementSection/telemetryManagementSection.plugin.js 27.5KB -973.7KB 1001.2KB
/bundles/plugin/tileMap/tileMap.plugin.js 806.3KB -1016.7KB 1.8MB
/bundles/plugin/transform/transform.plugin.js 21.6KB -34.5KB 56.1KB
/bundles/plugin/triggers_actions_ui/triggers_actions_ui.plugin.js 102.9KB -54.2KB 157.1KB
/bundles/plugin/uiActions/uiActions.plugin.js 159.8KB +628.0B 159.2KB
/bundles/plugin/uiActionsEnhanced/uiActionsEnhanced.plugin.js 84.8KB -609.1KB 693.9KB
/bundles/plugin/upgradeAssistant/upgradeAssistant.plugin.js 46.6KB -36.0KB 82.6KB
/bundles/plugin/uptime/uptime.plugin.js 327.1KB -15.5KB 342.7KB
/bundles/plugin/usageCollection/usageCollection.plugin.js 24.3KB +645.0B 23.7KB
/bundles/plugin/visTypeMarkdown/visTypeMarkdown.plugin.js 512.5KB +1016.0B 511.6KB
/bundles/plugin/visTypeMetric/visTypeMetric.plugin.js 536.7KB -366.4KB 903.2KB
/bundles/plugin/visTypeTable/visTypeTable.plugin.js 562.7KB -121.8KB 684.5KB
/bundles/plugin/visTypeTagcloud/visTypeTagcloud.plugin.js 797.1KB -99.6KB 896.8KB
/bundles/plugin/visTypeTimelion/visTypeTimelion.plugin.js 670.7KB +1.2KB 669.5KB
/bundles/plugin/visTypeTimeseries/visTypeTimeseries.plugin.js 217.9KB +754.0B 217.1KB
/bundles/plugin/visTypeVega/visTypeVega.plugin.js 580.3KB -1.2MB 1.8MB
/bundles/plugin/visTypeVislib/visTypeVislib.plugin.js 1.2MB -139.8KB 1.4MB
/bundles/plugin/visualizations/visualizations.plugin.js 343.7KB -641.5KB 985.2KB
/bundles/plugin/visualize/visualize.plugin.js 18.3KB -15.0KB 33.2KB
/bundles/plugin/watcher/watcher.plugin.js 35.2KB -34.8KB 70.0KB
/ui/fonts/inter_ui/Inter-UI-SemiBold.woff2 - -92.5KB 92.5KB
total - -17.9MB -

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger marked this pull request as ready for review June 17, 2020 00:41
@spalger spalger merged commit a0e2e97 into elastic:7.x Jun 17, 2020
@spalger spalger deleted the backport/7.x/pr-68986 branch June 17, 2020 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spalger @kibanamachine @elasticmachine