Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs UI] ML log integration splash screen #69288

Merged
merged 19 commits into from
Jun 25, 2020
Merged

[Logs UI] ML log integration splash screen #69288

merged 19 commits into from
Jun 25, 2020

Conversation

afgomez
Copy link
Contributor

@afgomez afgomez commented Jun 16, 2020 •
edited
Loading

Summary

Add a splash screen to ML integration pages, allowing users to start a trial period or upgrade to the right license if the features are not available for them.

Closes #64921

Checklist

Delete any items that are not applicable to this PR.

@afgomez afgomez added v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 labels Jun 16, 2020
@afgomez afgomez marked this pull request as ready for review June 16, 2020 15:39
@afgomez afgomez requested a review from a team as a code owner June 16, 2020 15:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@afgomez afgomez changed the title 64921 ml logs splash screen [Logs UI] ML log integration splash screen Jun 17, 2020
@afgomez
Copy link
Contributor Author

afgomez commented Jun 17, 2020

@elasticmachine merge upstream

@Kerry350 Kerry350 self-requested a review June 23, 2020 08:33
Kerry350
Kerry350 reviewed Jun 23, 2020
View reviewed changes
Copy link
Contributor

@Kerry350 Kerry350 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality LGTM 👍

However, I did leave a few comments around wording, small nits, and some stylistic suggestions.

Edit: Added a couple of extra comments. I think the runtime type checking and handling of the error state is quite important.

...k/plugins/infra/public/components/logging/log_analysis_setup/subscription_splash_content.tsx Outdated Show resolved Hide resolved
...k/plugins/infra/public/components/logging/log_analysis_setup/subscription_splash_content.tsx Outdated Show resolved Hide resolved
x-pack/plugins/infra/public/hooks/use_trial_state.tsx Outdated Show resolved Hide resolved
x-pack/plugins/infra/public/hooks/use_trial_state.tsx Outdated Show resolved Hide resolved
bmorelli25
bmorelli25 reviewed Jun 23, 2020
View reviewed changes
...k/plugins/infra/public/components/logging/log_analysis_setup/subscription_splash_content.tsx Outdated Show resolved Hide resolved
...k/plugins/infra/public/components/logging/log_analysis_setup/subscription_splash_content.tsx Outdated Show resolved Hide resolved
...k/plugins/infra/public/components/logging/log_analysis_setup/subscription_splash_content.tsx Outdated Show resolved Hide resolved
...k/plugins/infra/public/components/logging/log_analysis_setup/subscription_splash_content.tsx Outdated Show resolved Hide resolved
...k/plugins/infra/public/components/logging/log_analysis_setup/subscription_splash_content.tsx Outdated Show resolved Hide resolved
...k/plugins/infra/public/components/logging/log_analysis_setup/subscription_splash_content.tsx Outdated Show resolved Hide resolved
@afgomez @bmorelli25
Update copy
ebe00ef 
Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
@afgomez
Copy link
Contributor Author

afgomez commented Jun 24, 2020

@elasticmachine merge upstream

@sgrodzicki sgrodzicki added this to the Logs UI 7.9 milestone Jun 24, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Kerry350
Kerry350 approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@Kerry350 Kerry350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes 👌

@afgomez afgomez merged commit f6c9ca2 into elastic:master Jun 25, 2020
@afgomez afgomez deleted the 64921-ml-logs-splash-screen branch June 25, 2020 08:18
@afgomez afgomez mentioned this pull request Jun 25, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 25, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
9de574c 
* master: (45 commits)
  [QA] Unskip functional tests (elastic#69760)
  [SIEM][Detection Engine] - Update DE to work with new exceptions schema (elastic#69715)
  Fixes elastic#69639: Ignore url.url fields above 2048 characters (elastic#69863)
  PR: Provide limit warnings to user when API limits are reached. (elastic#69590)
  [Maps] Remove broken button (elastic#69853)
  Makes usage collection methods available on start (elastic#69836)
  [SIEM][CASE] Improve Jira's labelling (elastic#69892)
  [Logs UI] Access ML via the programmatic plugin API (elastic#68905)
  [ML] DF Analytics: Creation wizard part 3 (elastic#69456)
  Update Resolver generator script documentation (elastic#69912)
  [ML] Changes View results button text on new job page (elastic#69809)
  Add master branch to backport config (elastic#69893)
  [Ingest Manager] Kibana, not EPR, controls removable packages (elastic#69761)
  unskips 'Events columns' test (elastic#69684)
  [ML] Changes the ML overview empty analytics panel text (elastic#69801)
  [DOCS] Emphasizes where File Data Visualizer is located. (elastic#69812)
  add the `exactRoute` property to app registration (elastic#69772)
  Bump backport to 5.4.6 (elastic#69880)
  [Logs UI] ML log integration splash screen (elastic#69288)
  Clean up TSVB type client code to conform to the schema (elastic#68519)
  ...
afgomez pushed a commit that referenced this pull request Jun 25, 2020
@bmorelli25 @elasticmachine
[7.x] [Logs UI] ML log integration splash screen (#69288) (#69916)
4951124 
Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This was referenced Jul 3, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katrin-freihofner katrin-freihofner katrin-freihofner left review comments

@bmorelli25 bmorelli25 bmorelli25 left review comments

@Kerry350 Kerry350 Kerry350 approved these changes

Assignees
No one assigned
Labels
Feature:Logs UI Logs UI feature release_note:enhancement Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 v8.0.0
Projects
None yet
Milestone
Logs UI 7.9
Development

Successfully merging this pull request may close these issues.

[Logs UI] don't hide anomalies and categories tab if user has no premium license
7 participants
@afgomez @elasticmachine @kibanamachine @Kerry350 @bmorelli25 @katrin-freihofner @sgrodzicki