Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] PR #6909 to 4.5 #6930

Merged
merged 1 commit into from
Apr 14, 2016
Merged

[backport] PR #6909 to 4.5 #6930

merged 1 commit into from
Apr 14, 2016

Conversation

elastic-jasper
Copy link
Contributor

Backport PR #6909

Commit 1:
[internal] Replace var with let in ui/public P-T

This change was applied to any .js files under directories beginning
with p through t in src/ui/public. There are no o directories.

This was an automatic replacement from var to let for any variable
declaration that doubles as the initial assignment. Ultimately we want
most of these to be converted to const, but this commit is so large that
it warrants breaking each step of automation up into its own commit.

For example:

var foo = 'bar'; becomes let foo = 'var';

This was accomplished by replacing:
find: var ([a-zA-Z_$][0-9a-zA-Z_$]*)(\s+)=
replace: let $1$2=


Backported based on diff from PR #6922

---------

**Commit 1:**
[internal] Replace var with let in ui/public P-T

This change was applied to any .js files under directories beginning
with `p` through `t` in src/ui/public. There are no `o` directories.

This was an automatic replacement from var to let for any variable
declaration that doubles as the initial assignment. Ultimately we want
most of these to be converted to const, but this commit is so large that
it warrants breaking each step of automation up into its own commit.

For example:

`var foo = 'bar';` becomes `let foo = 'var';`

This was accomplished by replacing:
find: `var ([a-zA-Z_$][0-9a-zA-Z_$]*)(\s+)=`
replace: `let $1$2=`

* Original sha: 1cddaab
* Authored by Court Ewing <court@epixa.com> on 2016-04-12T22:31:57Z
@epixa epixa assigned epixa and unassigned panda01 Apr 14, 2016
@epixa epixa merged commit e10f821 into 4.5 Apr 14, 2016
@epixa epixa deleted the jasper/backport/6909/6922/4.5 branch April 14, 2016 19:31
epixa added a commit that referenced this pull request Jul 21, 2016
…22/4.5"

This reverts commit e10f821, reversing
changes made to d649471.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants