-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate dashboard mode #69305
Merged
Merged
Migrate dashboard mode #69305
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7a7bbdd
Migrate dashboard mode
alexwizp 13beb79
Merge branch 'master' into dashboard_mode
elasticmachine aafb506
Merge remote-tracking branch 'upstream/master' into dashboard_mode
alexwizp 0d1ae45
Merge remote-tracking branch 'upstream/master' into dashboard_mode
alexwizp e667266
Merge branch 'master' into dashboard_mode
elasticmachine 3cc13d2
Merge branch 'master' into dashboard_mode
elasticmachine 997ff31
Merge branch 'master' into dashboard_mode
elasticmachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
163 changes: 0 additions & 163 deletions
163
x-pack/legacy/plugins/dashboard_mode/server/__tests__/dashboard_mode_request_interceptor.js
This file was deleted.
Oops, something went wrong.
73 changes: 0 additions & 73 deletions
73
x-pack/legacy/plugins/dashboard_mode/server/dashboard_mode_request_interceptor.js
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elastic/ingest-management
Could you please help me to deal with that broken CI test
apis Fleet Endpoints fleet_setup should create a fleet_enroll user and role
?Not sure that it's somehow related to my changes but looks like my PR forced that problem #68568
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on my local it works fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elastic/ingest-management Could someone help out here, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this error, we currently have an external dependency in our tests (to the package registry), we are working to have it running locally, and avoid these one time errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nchaulet I changed the order of the tests a bit. Now everything passes. Could you take a look at this PR?
I was able to reproduce this problem locally, and it seems now everything is working correctly