Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monitoring] Fixed links missing a hash #69861

Merged
merged 2 commits into from
Jun 25, 2020
Merged

[Monitoring] Fixed links missing a hash #69861

merged 2 commits into from
Jun 25, 2020

Conversation

igoristic
Copy link
Contributor

Fixes: #69321
Fixes: #69625

We forgot to add a # in some links that use getSafeForExternalLink which forces it to use it as full path instead of hash change

@igoristic igoristic added bug Fixes for quality problems that affect the customer experience review release_note:fix Team:Monitoring Stack Monitoring team v8.0.0 v7.9.0 v7.8.1 labels Jun 24, 2020
@igoristic igoristic requested a review from a team June 24, 2020 22:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

@igoristic
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@igoristic igoristic merged commit 1ae5d32 into elastic:master Jun 25, 2020
@igoristic igoristic deleted the fix-broken-links branch June 25, 2020 04:23
@igoristic igoristic removed the review label Jun 25, 2020
This was referenced Jun 25, 2020
Merged
Merged
igoristic added a commit to igoristic/kibana that referenced this pull request Jun 25, 2020
@igoristic @elasticmachine
Fixed links missing a hash (elastic#69861)
1d4b979 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
igoristic added a commit that referenced this pull request Jun 25, 2020
@igoristic @elasticmachine
Fixed links missing a hash (#69861) (#69878)
39218e1 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
igoristic added a commit that referenced this pull request Jun 25, 2020
@igoristic @elasticmachine
Fixed links missing a hash (#69861) (#69877)
dd1d3dd 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@igoristic
Copy link
Contributor Author

Backport:
7.x: 12482c8
7.8: 1d4b979

tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request Jun 30, 2020
@igoristic @elasticmachine
Fixed links missing a hash (elastic#69861) (elastic#69878)
6cc67b8 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisronline chrisronline chrisronline approved these changes

Assignees
No one assigned
Labels
backported bug Fixes for quality problems that affect the customer experience release_note:fix Team:Monitoring Stack Monitoring team v7.8.1 v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stack Monitoring - Logstash Pipeline UI is returning 404 [Monitoring] Logstash node link is broken
4 participants
@igoristic @elasticmachine @kibanamachine @chrisronline