Use TS to discourage SO mappings with dynamic: false / dynamic: true #69927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudolf
added
Team:Core
rudolf
commented
Jun 25, 2020
| @@ -37,8 +37,8 @@ export const mapsTelemetrySavedObjects: SavedObjectsType = { | |||
| avg: { type: 'long' }, | |||
| }, | |||
| }, | |||
| layerTypesCount: { dynamic: 'true', properties: {} }, | |||
| emsVectorLayersCount: { dynamic: 'true', properties: {} }, | |||
| layerTypesCount: { type: 'object', enabled: false }, | |||
There was a problem hiding this comment.
This will prevent any queries on fields inside layerTypesCount. If we do need to be able to query this data we will have to change the data that's being indexed so that it conforms to a fixed schema instead of dynamically adding new fields.
|
Pinging @elastic/kibana-platform (Team:Platform) |
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
rudolf
added
the
release_note:skip
jfsiii
reviewed
Jun 25, 2020
There was a problem hiding this comment.
Ingest changes LGTM
cc @jonathan-buttner since that setting came in with https://github.com/elastic/kibana/pull/63016/files#diff-fc9ba47c2406eee475f1329c61a23227
💔 Build Failed
Failed CI StepsBuild metrics
History
To update your PR or re-run it, just comment with: |
|
Merging because the typescript failure happens on master too. |
rudolf
added a commit
to rudolf/kibana
that referenced
this pull request
Jun 26, 2020
…lastic#69927) * Use TS to discourage SO mappings with dynamic * Some unrelated docs changes
rudolf
added a commit
to rudolf/kibana
that referenced
this pull request
Jun 26, 2020
…lastic#69927) * Use TS to discourage SO mappings with dynamic * Some unrelated docs changes # Conflicts: # x-pack/plugins/ingest_manager/server/saved_objects/index.ts
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jun 26, 2020
…t-pipelines/editor-error-messages * ingest-pipelines/editor-dropzone-refinement: (122 commits) Fixes for monaco XJSON grammar parser and update form copy Added cancel move button Refactor SCSS values to variables use classNames as it is intended to be used Remove box shadow on all nested tree items Rename variables and prefix booleans with "is" Fixes bug on color picker defaults on TSVB (elastic#69889) [DOCS] Fixes wording in Upload a CSV section (elastic#69969) [Discover] Validate timerange before submitting query to ES (elastic#69363) [Maps] avoid using MAP_SAVED_OBJECT_TYPE constant when defining URL paths (elastic#69723) [Maps] Fix icon palettes are not working (elastic#69937) [Ingest Manager] Fix typo in constant name (elastic#69919) [test] skip status.allowAnonymous tests on cloud (elastic#69017) Fix backport (elastic#70003) [Reporting] ReportingStore module (elastic#69426) Add reporting assets to the eslint ignore file (elastic#69968) [Discover] set minBarHeight for high cardinality data (elastic#69875) Add featureUsage API to licensing context provider (elastic#69838) Fix uncaught typecheck merge conflict (elastic#70001) Use TS to discourage SO mappings with dynamic: false / dynamic: true (elastic#69927) ...
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
added
the
backport missing
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
rudolf
added a commit
that referenced
this pull request
Jun 30, 2020
… true (#69927) (#70062) * Use TS to discourage SO mappings with dynamic: false / dynamic: true (#69927) * Use TS to discourage SO mappings with dynamic * Some unrelated docs changes # Conflicts: # x-pack/plugins/ingest_manager/server/saved_objects/index.ts * @ts-ignore instead of @ts-expect-error * ingest_manager PACKAGES_SAVED_OBJECT_TYPE enabled: false Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When Saved Object types are registered with a mapping of
dynamic: truethere's a big risk that indexing will add hundreds of fields and eventually push the.kibanaindex over the default ES field limit of 1000. Althoughdynamic: falsewon't cause a mappings explosion it's preferable to simply usetype: "object", enabled: falseso that no fields are being indexed.We should probably add runtime validation as well, but this provides a quick stop gap for #69985
Checklist
Delete any items that are not applicable to this PR.
For maintainers