Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] integrate new translations + new i18n check #70193

Closed
wants to merge 99 commits into from

Conversation

Bamieh
Copy link
Member

@Bamieh Bamieh commented Jun 29, 2020

Closed in favor of #70423

sorry for the pings 😬

@Bamieh Bamieh added Project:i18n v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v7.8.1 labels Jun 29, 2020
@Bamieh Bamieh requested a review from afharo June 29, 2020 13:24
@Bamieh Bamieh requested a review from a team as a code owner June 29, 2020 13:24
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Bamieh Bamieh requested review from a team as code owners July 1, 2020 11:28
@Bamieh Bamieh requested a review from a team July 1, 2020 11:28
@Bamieh Bamieh requested review from a team as code owners July 1, 2020 11:28
@Bamieh Bamieh requested a review from a team July 1, 2020 11:28
@Bamieh Bamieh requested a review from a team as a code owner July 1, 2020 11:28
@botelastic botelastic bot added Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:Fleet Team label for Observability Data Collection Fleet team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Jul 1, 2020
alisonelizabeth and others added 6 commits July 1, 2020 14:30
* add application result provider

* remove empty contracts & cache searchable apps

* fix types
* [APM] Use licensing from context

We added the usage of `featureUsage.notifyUsage` from the licensing plugin in elastic#69455.

This required us to use `getStartServices to add `licensing` to `context.plugins`.

In elastic#69838 `featureUsage` was added to `context.licensing`, so we don't need to add it to `context.plugins`.
…stic#69822)

* Partially disable test files.

* Use DockerServers in EPM tests.

* Only run tests when DockerServers have been set up

* Reenable ingest manager API integration tests

* Pass new test_packages to registry container

* Enable DockerServers tests in CI.

* Correctly serve filetest package for file tests.

* Add helper to skip test and log warning.

* Reenable further file tests.

* Add developer documentation about Docker in Kibana CI.

* Document use of yarn test:ftr

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
…6921)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
brianseeders and others added 10 commits July 1, 2020 14:31
…c#70090)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Shahzad <shahzad31comp@gmail.com>
…stic#70047)

* refactor: 💡 rename folder to "explore_data"

* style: 💄 check for "share" plugin in more semantic way

"explore data" actions use Discover URL generator, which is registered
in "share" plugin, which is optional plugin, so we check for its
existance, because otherwise URL generator is not available.

* refactor: 💡 move KibanaURL to a separate file

* feat: 🎸 add "Explore underlying data" in-chart action

* fix: 🐛 fix imports after refactor

* feat: 🎸 add start.filtersFromContext to embeddable plugin

* feat: 🎸 add type checkers to data plugin

* feat: 🎸 better handle empty filters in Discover URL generator

* feat: 🎸 implement .getUrl() method of explore data in-chart act

* feat: 🎸 add embeddable.filtersAndTimeRangeFromContext()

* feat: 🎸 improve getUrl() method of explore data action

* test: 💍 update test mock

* fix possible stale hashHistory.location in discover

* style: 💄 ensureHashHistoryLocation -> syncHistoryLocations

* docs: ✏️ update autogenerated docs

* test: 💍 add in-chart "Explore underlying data" unit tests

* test: 💍 add in-chart "Explore underlying data" functional tests

* test: 💍 clean-up custom time range after panel action tests

* chore: 🤖 fix embeddable plugin mocks

* chore: 🤖 fix another mock

* test: 💍 add support for new action to pie chart service

* feat: 🎸 enable "Explore underlying data" action for Lens vis

* test: 💍 make tests green again

* refactor: 💡 rename trigger contexts

* chore: 🤖 fix TypeScript errors

Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This reverts commit 560ade34be57f524b54e39684eed52ed3de83af2.
@Bamieh Bamieh force-pushed the i18n/7_8_2_master branch from 9caee3d to 999f638 Compare July 1, 2020 11:32
@Bamieh Bamieh requested a review from a team as a code owner July 1, 2020 11:32
@Bamieh Bamieh requested a review from a team July 1, 2020 11:32
@Bamieh Bamieh requested review from a team as code owners July 1, 2020 11:32
@Bamieh Bamieh closed this Jul 1, 2020
@kibanamachine
Copy link
Contributor

💔 Build Failed

Failed CI Steps

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
data 199 -10 209
discover 83 +3 80
kibanaUtils 158 -1 159
visualize 184 +9 175
apm 652 -6 658
beats_management 174 -9 183
canvas 782 -14 796
crossClusterReplication 60 -2 62
globalSearchProviders 3 +3 -
graph 92 -2 94
indexLifecycleManagement 92 -2 94
indexManagement 142 -2 144
infra 598 -8 606
ingestManager 353 -7 360
lens 88 +5 83
licenseManagement 91 -2 93
maps 455 -1 456
observability 11 -9 20
remoteClusters 66 -2 68
rollup 131 -2 133
securitySolution 787 -1 788
uptime 251 -9 260
total - -69 -

History

  • 💚 Build #57184 succeeded 560ade34be57f524b54e39684eed52ed3de83af2
  • 💔 Build #57110 failed 06687d058e213778149ff817a21fc8720b102a7f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Bamieh added a commit that referenced this pull request Jul 1, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Bamieh added a commit to Bamieh/kibana that referenced this pull request Jul 1, 2020
…stic#70423)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json
mistic added a commit to mistic/kibana that referenced this pull request Jul 8, 2020
Bamieh added a commit to Bamieh/kibana that referenced this pull request Jul 11, 2020
…stic#70423)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json
Bamieh added a commit that referenced this pull request Jul 11, 2020
…) (#71388)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Bamieh added a commit that referenced this pull request Jul 11, 2020
…) (#71389)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Project:i18n release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.8.1 v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.