-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[i18n] integrate new translations + new i18n check #70193
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bamieh
added
Project:i18n
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
v7.9.0
v7.8.1
labels
Jun 29, 2020
afharo
approved these changes
Jun 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
botelastic
bot
added
Feature:ExpressionLanguage
Interpreter expression language (aka canvas pipeline)
Team:Fleet
Team label for Observability Data Collection Fleet team
Team:Uptime - DEPRECATED
Synthetics & RUM sub-team of Application Observability
labels
Jul 1, 2020
* add application result provider * remove empty contracts & cache searchable apps * fix types
* [APM] Use licensing from context We added the usage of `featureUsage.notifyUsage` from the licensing plugin in elastic#69455. This required us to use `getStartServices to add `licensing` to `context.plugins`. In elastic#69838 `featureUsage` was added to `context.licensing`, so we don't need to add it to `context.plugins`.
…stic#69822) * Partially disable test files. * Use DockerServers in EPM tests. * Only run tests when DockerServers have been set up * Reenable ingest manager API integration tests * Pass new test_packages to registry container * Enable DockerServers tests in CI. * Correctly serve filetest package for file tests. * Add helper to skip test and log warning. * Reenable further file tests. * Add developer documentation about Docker in Kibana CI. * Document use of yarn test:ftr Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
…6921) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
…c#70090) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Shahzad <shahzad31comp@gmail.com>
…stic#70047) * refactor: 💡 rename folder to "explore_data" * style: 💄 check for "share" plugin in more semantic way "explore data" actions use Discover URL generator, which is registered in "share" plugin, which is optional plugin, so we check for its existance, because otherwise URL generator is not available. * refactor: 💡 move KibanaURL to a separate file * feat: 🎸 add "Explore underlying data" in-chart action * fix: 🐛 fix imports after refactor * feat: 🎸 add start.filtersFromContext to embeddable plugin * feat: 🎸 add type checkers to data plugin * feat: 🎸 better handle empty filters in Discover URL generator * feat: 🎸 implement .getUrl() method of explore data in-chart act * feat: 🎸 add embeddable.filtersAndTimeRangeFromContext() * feat: 🎸 improve getUrl() method of explore data action * test: 💍 update test mock * fix possible stale hashHistory.location in discover * style: 💄 ensureHashHistoryLocation -> syncHistoryLocations * docs: ✏️ update autogenerated docs * test: 💍 add in-chart "Explore underlying data" unit tests * test: 💍 add in-chart "Explore underlying data" functional tests * test: 💍 clean-up custom time range after panel action tests * chore: 🤖 fix embeddable plugin mocks * chore: 🤖 fix another mock * test: 💍 add support for new action to pie chart service * feat: 🎸 enable "Explore underlying data" action for Lens vis * test: 💍 make tests green again * refactor: 💡 rename trigger contexts * chore: 🤖 fix TypeScript errors Co-authored-by: Anton Dosov <anton.dosov@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This reverts commit 560ade34be57f524b54e39684eed52ed3de83af2.
💔 Build Failed
Failed CI StepsBuild metrics@kbn/optimizer bundle module count
History
To update your PR or re-run it, just comment with: |
Bamieh
added a commit
that referenced
this pull request
Jul 1, 2020
This was referenced Jul 1, 2020
Bamieh
added a commit
to Bamieh/kibana
that referenced
this pull request
Jul 1, 2020
…stic#70423) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Jul 8, 2020
(elastic#70423)" This reverts commit 2212beb.
This was referenced Jul 11, 2020
Bamieh
added a commit
to Bamieh/kibana
that referenced
this pull request
Jul 11, 2020
…stic#70423) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json
Bamieh
added a commit
that referenced
this pull request
Jul 11, 2020
Bamieh
added a commit
that referenced
this pull request
Jul 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:ExpressionLanguage
Interpreter expression language (aka canvas pipeline)
Project:i18n
release_note:skip
Skip the PR/issue when compiling release notes
Team:Fleet
Team label for Observability Data Collection Fleet team
Team:Uptime - DEPRECATED
Synthetics & RUM sub-team of Application Observability
v7.8.1
v7.9.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed in favor of #70423
sorry for the pings 😬