fix export response #70473
Merged
fix export response #70473
+156
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angorayc
added
Team:SIEM
v7.9.0
v8.0.0
release_note:skip
|
Pinging @elastic/siem (Team:SIEM) |
stephmilovic
reviewed
Jul 1, 2020
| const fetchMock = jest.fn(); | ||
|
|
||
| beforeAll(() => { | ||
| jest.resetAllMocks(); |
There was a problem hiding this comment.
the jest resets seem repetitive, happening twice in beforeAll and afterAll... is that necessary? same thing in each describe. can we cut these down?
There was a problem hiding this comment.
maybe a beforeEach would eliminate the need within the describes? idk, give it a try
There was a problem hiding this comment.
yeah, I think keep reset in just beforeAll would be enough
stephmilovic
approved these changes
Jul 1, 2020
There was a problem hiding this comment.
code review and manual testing (export timelines ✅ , export template timelines ✅ , export elastic templates ❌ ) all looks good... i just have the one nit on jest.reset. thanks for the fix @angorayc LGTM!
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
angorayc
added a commit
to angorayc/kibana
that referenced
this pull request
Jul 1, 2020
* fix export response * update unit tests
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 2, 2020
* master: (46 commits) [Visualize] Add missing advanced settings and custom label for pipeline aggs (elastic#69688) Use dynamic: false for config saved object mappings (elastic#70436) [Ingest Pipelines] Error messages (elastic#70167) [APM] Show transaction rate per minute on Observability Overview page (elastic#70336) Filter out error when calculating a label (elastic#69934) [Visualizations] Each visType returns its supported triggers (elastic#70177) [Telemetry] Report data shippers (elastic#64935) Reduce SavedObjects mappings for Application Usage (elastic#70475) [Lens] fix dimension label performance issues (elastic#69978) Skip failing endgame tests (elastic#70548) [SIEM] Reenabling Cypress tests (elastic#70397) [SIEM][Security Solution][Endpoint] Endpoint Artifact Manifest Management + Artifact Download and Distribution (elastic#67707) [Security] Adds field mapping support to rule creation (elastic#70288) SECURITY-ENDPOINT: add fields for events to metadata document (elastic#70491) Fixed assertion in hybrid index pattern test to iterate through indices (elastic#70130) [SIEM][Exceptions] - Exception builder component (elastic#67013) [Ingest Manager] Rename data sources to package configs (elastic#70259) skip suites blocking es snapshot promomotion (elastic#70532) [Metrics UI] Fix asynchronicity and error handling in Snapshot API (elastic#70503) fix export response (elastic#70473) ...
angorayc
added a commit
that referenced
this pull request
Jul 2, 2020
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to fix the broken export functionality.
Steps to verify:
Click on the
export buttonfor those exportable timeline / templates and see if it completed successfully.To get some sample Elastic templates, you can download, rename it to
.ndjsonand import this file:index copy.txt
Checklist
Delete any items that are not applicable to this PR.
Documentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityThis renders correctly on smaller devices using a responsive layout. (You can test this in your browserThis was checked for cross-browser compatibility, including a check against IE11For maintainers
This was checked for breaking API changes and was labeled appropriately