Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Improve no data popover styles #70594

Merged
merged 7 commits into from
Jul 6, 2020
Merged

[Lens] Improve no data popover styles #70594

merged 7 commits into from
Jul 6, 2020

Conversation

flash1293
Copy link
Contributor

@flash1293 flash1293 commented Jul 2, 2020 •
edited
Loading

Super small follow up (#69147 (comment))

Improves styles of the "no data" popover dismiss button

Before
Screenshot 2020-07-02 at 15 27 51

After
Screenshot 2020-07-03 at 09 53 12

@flash1293 flash1293 added release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0 labels Jul 2, 2020
@flash1293 flash1293 marked this pull request as ready for review July 2, 2020 15:09
@flash1293 flash1293 requested a review from a team as a code owner July 2, 2020 15:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@flash1293 flash1293 requested a review from cchaos July 2, 2020 15:09
cchaos
cchaos reviewed Jul 2, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo, thanks!! Maybe we should also add in a title="Empty dataset" or whatever we should call the currently selected timerange of data.

@cchaos
Copy link
Contributor

cchaos commented Jul 3, 2020 via email

@cchaos
Copy link
Contributor

cchaos commented Jul 3, 2020 via email

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

ppisljar
ppisljar approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@flash1293 flash1293 merged commit 3bddc4a into elastic:master Jul 6, 2020
flash1293 added a commit to flash1293/kibana that referenced this pull request Jul 6, 2020
@flash1293
[Lens] Improve no data popover styles (elastic#70594)
b06d7ac
@flash1293 flash1293 mentioned this pull request Jul 6, 2020
Merged
flash1293 added a commit that referenced this pull request Jul 7, 2020
@flash1293
[Lens] Improve no data popover styles (#70594) (#70816)
8f158b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos left review comments

@ppisljar ppisljar ppisljar approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@flash1293 @elasticmachine @cchaos @kibanamachine @ppisljar