Fix coordinate maps layers dropdown #70609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kindsun
added
Feature:Coordinate Map
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
kindsun
force-pushed
the
fix-base-layer-settings-dropdown
branch
from
e1c88ab to
79875b0
Compare
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
thomasneirynck
approved these changes
Jul 14, 2020
There was a problem hiding this comment.
Code review lgtm, thx!
Agreed to address #68818 separately since the expectation is that that fix will fix both Coordinate/region maps and the Maps-app.
kindsun
pushed a commit
that referenced
this pull request
Jul 14, 2020
kindsun
pushed a commit
to kindsun/kibana
that referenced
this pull request
Jul 14, 2020
kindsun
pushed a commit
that referenced
this pull request
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #70374. Coordinate maps use
service_settingsto obtain TMS Layers but this wasn't getting passed.I also checked region maps. Service settings are getting passed there and the dropdown functions as expected.
The dropdown doesn't seem to include the configured TMS even with this fix in place, however I believe this is a separate issue affecting all maps apps identified in #68818