Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[savedObjects field count] run in baseline job #70999

Merged
merged 1 commit into from
Jul 7, 2020
Merged

[savedObjects field count] run in baseline job #70999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion test/scripts/jenkins_xpack_visual_regression.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ source "$KIBANA_DIR/src/dev/ci_setup/setup_percy.sh"

echo " -> building and extracting default Kibana distributable"
cd "$KIBANA_DIR"
node scripts/build --debug --no-oss
node scripts/build --debug
linuxBuild="$(find "$KIBANA_DIR/target" -name 'kibana-*-linux-x86_64.tar.gz')"
installDir="$PARENT_DIR/install/kibana"
mkdir -p "$installDir"
Expand All @@ -21,3 +21,6 @@ yarn percy exec -t 10000 -- -- \

# cd "$KIBANA_DIR"
# source "test/scripts/jenkins_xpack_page_load_metrics.sh"

cd "$XPACK_DIR"
source "$KIBANA_DIR/test/scripts/jenkins_xpack_saved_objects_field_metrics.sh"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't test/scripts/jenkins_xpack_visual_regression.sh going to be called outside of the baseline job?

If so, jenkins_xpack_saved_objects_field_metrics.sh is run elsewhere, so would run twice

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't currently, and we won't be re-enabling the visual regression tests on master/PRs until after I've refactored the baseline job (and a few other blockers are resolved) so I don't think it's a serious issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely crufty though

2 changes: 1 addition & 1 deletion vars/tasks.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def functionalXpack(Map params = [:]) {
firefox: true,
accessibility: true,
pluginFunctional: true,
savedObjectsFieldMetrics:true,
savedObjectsFieldMetrics: true,
pageLoadMetrics: false,
visualRegression: false,
]
Expand Down